Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video helper destroying input frame list #302

Closed
kelleyl opened this issue Aug 9, 2024 · 0 comments · Fixed by #303
Closed

Video helper destroying input frame list #302

kelleyl opened this issue Aug 9, 2024 · 0 comments · Fixed by #303

Comments

@kelleyl
Copy link
Contributor

kelleyl commented Aug 9, 2024

mmif-python/mmif/utils/video_document_helper.py

Line 98 in 2e17432

framenums.pop(0)

The extract_frames_as_images function modifies the input list framenums in-place by using framenums.pop(0). This can lead to unexpected behavior if the framenums list is used later because it will be empty.

Could fix this by copying the list first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
infra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the issue of extract_frames_as_images destory input frame clamsproject/mmif-python
2 participants
@kelleyl @1192119703jzx