Skip to content

Commit c9df2d5

Browse files
authored
Merge pull request #168 from clarin-eric/dev
Dev
2 parents 7710281 + 65e21b1 commit c9df2d5

File tree

6 files changed

+36
-22
lines changed

6 files changed

+36
-22
lines changed

curation-api/src/main/java/eu/clarin/cmdi/curation/api/subprocessor/collection/CollectionAggregator.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -209,12 +209,10 @@ public synchronized void addReport(CollectionReport collectionReport, CMDInstanc
209209
collectionReport.xmlValidityReport.aggregatedScore += instanceReport.xmlValidityReport.score;
210210

211211
// Facet
212-
synchronized (this) {
213-
instanceReport.facetReport.coverages.stream().filter(coverage -> coverage.coveredByInstance)
214-
.forEach(instanceFacet -> collectionReport.facetReport.facets.stream()
215-
.filter(collectionFacet -> collectionFacet.name.equals(instanceFacet.name)).findFirst()
216-
.get().count++);
217-
}
212+
instanceReport.facetReport.coverages.stream().filter(coverage -> coverage.coveredByInstance)
213+
.forEach(instanceFacet -> collectionReport.facetReport.facets.stream()
214+
.filter(collectionFacet -> collectionFacet.name.equals(instanceFacet.name)).findFirst()
215+
.get().count++);
218216
}
219217
else {
220218
collectionReport.fileReport.numOfFilesNonProcessable++;

curation-api/src/main/java/eu/clarin/cmdi/curation/api/subprocessor/instance/FileSizeValidator.java

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -192,18 +192,21 @@ public void process(CMDInstance instance, CMDInstanceReport report){
192192
}
193193

194194
CMDIData<Map<String, List<ValueSet>>> cmdiData = null;
195-
196-
try {
197-
cmdiData = processor.process(instance.getPath().toFile(), new ResourceStructureGraph());
198-
}
199-
catch (Exception e) {
200-
201-
log.debug("can't create CMDData object from file '{}'", instance.getPath());
202-
report.details.add(new Detail(Severity.FATAL, "file", "can't parse file '" + instance.getPath().getFileName() + "'"));
203-
report.isProcessable=false;
204-
205-
return;
195+
196+
synchronized(this) { // the use of the process method has to be synchronized since it's not thread-safe
206197

198+
try {
199+
200+
cmdiData = processor.process(instance.getPath().toFile(), new ResourceStructureGraph());
201+
}
202+
catch (Exception e) {
203+
204+
log.debug("can't create CMDData object from file '{}'", instance.getPath());
205+
report.details.add(new Detail(Severity.FATAL, "file", "can't parse file '" + instance.getPath().getFileName() + "'"));
206+
report.isProcessable=false;
207+
208+
return;
209+
}
207210
}
208211

209212

curation-app/src/main/java/eu/clarin/cmdi/curation/app/CurationApp.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,10 +118,17 @@ public CommandLineRunner commandLineRunner(ApplicationContext ctx) {
118118
if("all".equalsIgnoreCase(conf.getMode())) {
119119
log.info("start deactivating links older than {} days", conf.getLinkDeactivationAfter());
120120
linkService.deactivateLinksOlderThan(conf.getLinkDeactivationAfter());
121-
log.info("done deactivating links older than {} days", conf.getLinkDeactivationAfter());
121+
log.info("done deactivating links");
122122
log.info("start deleting links older than {} days", conf.getLinkDeletionAfter());
123123
linkService.deleteLinksOderThan(conf.getLinkDeletionAfter());
124-
log.info("done deleting links older than {} days", conf.getLinkDeletionAfter());
124+
log.info("done deleting links");
125+
log.info("start purging history table from records checked before {} days", conf.getPurgeHistoryAfter());
126+
linkService.purgeHistory(conf.getPurgeHistoryAfter());
127+
log.info("done purging history");
128+
log.info("start purging obsolete table from records checked before {} days", conf.getPurgeObsoleteAfter());
129+
linkService.purgeObsolete(conf.getPurgeObsoleteAfter());
130+
log.info("done purging obsolete");
131+
125132
}
126133

127134
log.info("end time: {}", LocalDateTime.now());

curation-app/src/main/java/eu/clarin/cmdi/curation/app/conf/AppConfig.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,10 @@ public class AppConfig {
3131

3232
private int linkDeletionAfter;
3333

34+
private int purgeHistoryAfter;
35+
36+
private int purgeObsoleteAfter;
37+
3438
@Data
3539
public static class Directory {
3640

curation-app/src/main/resources/application.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,4 +61,6 @@ curation:
6161
doc_url:
6262
clientUsername: curation
6363
link_deactivation_after: ${LINK_DEACTIVATION_AFTER:365}
64-
link_deletion_after: ${LINK_DELETION_AFTER:365}
64+
link_deletion_after: ${LINK_DELETION_AFTER:365}
65+
purge_history_after: ${PURGE_HISTORY_AFTER:365}
66+
purge_obsolete_after: ${PURGE_OBSOLETE_AFTER:100}

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
<maven.compiler.source>17</maven.compiler.source>
2020
<maven.compiler.target>17</maven.compiler.target>
2121
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
22-
<linkchecker-persistence.version>0.0.5</linkchecker-persistence.version>
23-
<global.version>6.0.2</global.version>
22+
<linkchecker-persistence.version>0.0.6</linkchecker-persistence.version>
23+
<global.version>6.0.3</global.version>
2424
<vlo.version>4.11.3</vlo.version>
2525
</properties>
2626
<dependencies>

0 commit comments

Comments
 (0)