Skip to content

Commit 8d46300

Browse files
committed
Don't quote URL, instead allow to embed a placeholder in quored strings
1 parent 35906ec commit 8d46300

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

host/host.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,16 +119,20 @@ func Launch(path string, defaultArgs []string, url string) {
119119
args := []string{}
120120
replacedPlaceholder := false
121121
for _, arg := range defaultArgs {
122-
if arg == "%s" || arg == "%**" {
123-
args = append(args, url)
122+
if strings.Contains(arg, "%s") {
123+
args = append(args, strings.Replace(arg, "%s", url, 1))
124+
replacedPlaceholder = true
125+
} else if strings.Contains(arg, "%**") {
126+
args = append(args, strings.Replace(arg, "%**", url, 1))
124127
replacedPlaceholder = true
125128
} else {
126129
args = append(args, arg)
127130
}
128131
}
129132
if !replacedPlaceholder {
130-
args = append(args, "\""+url+"\"")
133+
args = append(args, url)
131134
}
135+
LogForInfo("Args: \n " + strings.Join(args, "\n "))
132136
command := exec.Command(path, args...)
133137

134138
if !strings.HasPrefix(os.Args[1], "chrome-extension://") { // non-Chromium caller => Firefox

0 commit comments

Comments
 (0)