better truncation to ensure sheet names stay <= 31 characters, even for scvceps

Author: bpow

app/Modules/Group/Actions/SubgroupMembersMakeExcel.php

@@ -2,6 +2,7 @@
 namespace App\Modules\Group\Actions;
 
 use Carbon\Carbon;
+use Illuminate\Support\Str;
 use App\Modules\Group\Models\Group;
 use Lorisleiva\Actions\ActionRequest;
 use OpenSpout\Common\Entity\Row;
@@ -93,9 +94,9 @@ private function writeAllSheet($writer, $group)
 
     private function writeGroupSheet($writer, $group) {
         $sheet = $writer->addNewSheetAndMakeItCurrent();
-        $sheetName = $group->name.' '.$group->type->display_name;
-        if (strlen($group->name) > 26) {
-            $sheetName = substr($group->name, 0, 23).'... '. $group->type->display_name;
+        $sheetName = $group->name.' '.Str::upper($group->type->name);
+        if (strlen($group->name) > 25) {
+            $sheetName = substr($group->name, 0, 22).'... '. Str::upper($group->type->name);
         }
         $sheet->setName(preg_replace('/[\/\?\*\[\]\\\:]/', '', $sheetName));