Finish replacing client-side group-type eval with server-based attributes

replaces the commit in #105

Author: bpow

resources/js/components/expert_panels/AttestationNhgri.vue

@@ -24,7 +24,7 @@ export default {
             get () {
                 return this.$store.getters['groups/currentItemOrNew'];
             },
-            set (value) {                
+            set (value) {
                 this.$store.commit('groups/addItem', value);
             }
         },
@@ -38,7 +38,7 @@ export default {
                 } else {
                     this.group.expert_panel.nhgri_attestation_date = null;
                 }
-                this.$emit('update');                
+                this.$emit('update');
             }
         },
         checkboxLabel () {
@@ -66,8 +66,8 @@ export default {
 </script>
 <template>
   <div>
-    <p v-if="group.isVcep()">
-      Curated variants and genes are expected to be approved and posted for the community as soon as possible as described in Section 2.4 of the <vcep-protocol-link />. 
+    <p v-if="group.is_vcep">
+      Curated variants and genes are expected to be approved and posted for the community as soon as possible as described in Section 2.4 of the <vcep-protocol-link />.
       Note that upon approval, a VCEP must finalize their set of variants for upload to the ClinGen Evidence Repository within 30 days.
     </p>
     <p v-if="group.is_gcep">
@@ -76,10 +76,10 @@ export default {
 
     <p class="my-4">
       <input-row label="" :vertical="true">
-        <checkbox 
-          id="nhgri-checkbox" 
-          v-model="attestation" 
-          :disabled="disabled" 
+        <checkbox
+          id="nhgri-checkbox"
+          v-model="attestation"
+          :disabled="disabled"
           :label="checkboxLabel"
         />
       </input-row>
@@ -94,4 +94,4 @@ export default {
       <em>It is expected that, whenever possible, Expert Panel manuscripts will be pre-published (e.g. medRXiv) . If the authors do not anticipate submitting their manuscript to a prepublication resource they must provide a written justification.</em>
     </p>
   </div>
-</template>
+</template>

resources/js/components/groups/MemberForm.vue

@@ -401,7 +401,7 @@ export default {
           </div>
           <transition name="fade-down">
             <div
-              v-if="newMember.hasRole('biocurator') && group.isVcep()"
+              v-if="newMember.hasRole('biocurator') && group.is_vcep"
               class="border-t mt-2 pt-2 pl-2"
             >
               <h4>Training</h4>

resources/js/components/log_entries/ActivityLogEntryForm.vue

@@ -96,7 +96,7 @@
       :errors="errors.log_date"
       type="date"
     />
-    <StepInput v-if="group.isVcep()" v-model="newEntry.step" :errors="errors.step" />
+    <StepInput v-if="group.is_vcep" v-model="newEntry.step" :errors="errors.step" />
     <input-row label="Entry" :errors="errors.entry">
       <RichTextEditor v-model="newEntry.entry" />
     </input-row>

resources/js/domain/group.js

@@ -190,14 +190,6 @@ class Group extends Entity {
         return this.attributes.group_type_id === configs.groups.types.cdwg.id;
     }
 
-    isVcep() {
-        return this.is_vcep;
-    }
-
-    isGcep() {
-        return this.is_gcep;
-    }
-
     documentsOfType(docTypeId) {
         return this.documents.filter(d =>  d.document_type_id === docTypeId)
     }