Skip to content

Commit 7b1a9ee

Browse files
committed
Now handling user registration through Passport instead of GraphQL. Just so we don't have to reimplement the whole user workflow.
1 parent f129edb commit 7b1a9ee

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

Diff for: src/data/Schema.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -234,14 +234,14 @@ export const resolvers = {
234234
return context.NewsItem.hideNewsItem(id, context.userId);
235235
},
236236

237-
submitNewsItem: (_, args, context) => {
237+
submitNewsItem: (_, newsItem, context) => {
238238
if (!context.userId) throw new Error('Must be logged in to submit a news item.');
239-
return context.NewsItem.submitNewsItem({ ...args, submitterId: context.userId });
239+
return context.NewsItem.submitNewsItem({ ...newsItem, submitterId: context.userId });
240240
},
241241

242-
registerUser: (_, args, context) => {
242+
registerUser: (_, user, context) => {
243243
if (context.userId) throw new Error('Logged in user cannot register a user');
244-
return context.User.registerUser(args);
244+
return context.User.registerUser(user);
245245
},
246246
},
247247

Diff for: src/pages/login.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ const Page = ({ registerUser, url }) => {
8888
</tbody>
8989
</table>
9090
<br />
91-
<input type="submit" value="create account" onClick={() => registerUser(user, pass)} />
91+
<input type="submit" value="create account" /* onClick={() => registerUser(user, pass)} */ />
9292
</form>
9393
</Blank>
9494
);

Diff for: src/server.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,13 @@ app.prepare()
8484
server.use(passport.session());
8585

8686
server.post('/login', (req, res, next) => {
87-
if (req.body.creating) req.session.returnTo = `${req.body.goto}${req.body.username}`;
88-
else req.session.returnTo = req.body.goto;
87+
if (req.body.creating && !req.user) {
88+
User.registerUser({
89+
id: req.body.username,
90+
password: req.body.password,
91+
});
92+
req.session.returnTo = `${req.body.goto}${req.body.username}`;
93+
} else req.session.returnTo = req.body.goto;
8994
next();
9095
}, passport.authenticate(
9196
'local',

0 commit comments

Comments
 (0)