Skip to content

Commit 00e02b2

Browse files
committed
GA_TAG_ID in config, check if empty
1 parent 337da53 commit 00e02b2

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

shadow-cljs.edn

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
:closure-defines {codes.clj.docs.frontend.config/BASE_URL #shadow/env ["BASE_URL"]
1818
codes.clj.docs.frontend.config/CLIENT_ID #shadow/env ["CLIENT_ID"]
1919
codes.clj.docs.frontend.config/REDIRECT_URI #shadow/env ["REDIRECT_URI"]
20-
codes.clj.docs.frontend.infra.analytics/GA_TAG_ID #shadow/env ["GA_TAG_ID"]}}
20+
codes.clj.docs.frontend.config/GA_TAG_ID #shadow/env ["GA_TAG_ID"]}}
2121
:build-hooks [(codes.clj.docs.frontend.dev.shadow.hooks/hashed-files
2222
["resources/public/css/app.css"
2323
"resources/public/js/core.js"])

src/codes/clj/docs/frontend/config.cljs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,14 @@
2020
(goog-define BASE_URL "https://docs-backend.fly.dev/api/")
2121
(goog-define CLIENT_ID "46d86692f00ed9c613a1")
2222
(goog-define REDIRECT_URI "https://docs.clj.codes/github-callback")
23+
(goog-define GA_TAG_ID "")
2324

2425
(def config
2526
(let [debug? goog.DEBUG]
2627
{:debug? debug?
28+
:ga-tag-id (if debug?
29+
""
30+
GA_TAG_ID)
2731
:base-url (if debug?
2832
"http://localhost:3001/api/"
2933
BASE_URL)

src/codes/clj/docs/frontend/infra/analytics.cljs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
(ns codes.clj.docs.frontend.infra.analytics)
2-
3-
(goog-define GA_TAG_ID "G-0123456789")
1+
(ns codes.clj.docs.frontend.infra.analytics
2+
(:require [codes.clj.docs.frontend.infra.system.state :as system.state]))
43

54
(defn google-tag-manager
65
[ga-tag-id]
@@ -22,5 +21,7 @@
2221
(js/document.head.insertBefore script (.-nextSibling gtm-script))))
2322

2423
(defn google-analytics []
25-
(let [gtm-script (google-tag-manager GA_TAG_ID)]
26-
(google-tag GA_TAG_ID gtm-script)))
24+
(let [ga-tag-id (-> @system.state/components :config :ga-tag-id)]
25+
(when (seq ga-tag-id)
26+
(let [gtm-script (google-tag-manager ga-tag-id)]
27+
(google-tag ga-tag-id gtm-script)))))

0 commit comments

Comments
 (0)