Skip to content

Commit 9523108

Browse files
committed
fix zetasketch (credit @brandonstubbs)
1 parent ae70620 commit 9523108

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ Here the list of libraries tested:
5757
| :white_check_mark: | [pedestal](./pedestal) | Pedestal is a sturdy and reliable base for services and APIs. | |
5858
| :white_check_mark: | [claypoole](./claypoole) | Claypoole: Threadpool tools for Clojure | |
5959
| :white_check_mark: | [upit](./upit) | Very very simple library to initialise your app stack. | |
60-
| :warning: | [zetasketch](./zetasketch) | Sketch data structures like HLL | Serialization doesn't work |
60+
| ::white_check_mark:| [zetasketch](./zetasketch) | Sketch data structures like HLL | requires reflect-config.json |
6161

6262

6363
More libraries to come (*PRs are welcome*).

zetasketch/README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,10 @@ alternatively use a Dockerized versions:
1919
Add any info might be useful for the reader.
2020

2121

22-
## Error
22+
## Error fixed
2323

2424
Zetasketch doesn't work due to ProtoBuf serialize error.
2525

26-
This error appears in AMD64 version of GraalVM 20.0.2. Adding the [reflect-config.json](./resources/META-INF/native-image/com.google/zetasketch/reflect-config.json) seems to fix the issue in some platform/version but not all.
27-
2826
```
2927
"RESULT1:" 3
3028
"DATA1:" [0 0 0 0 0 0 0 0 8 112 16 3 24 2 32 11 -126 7 17 -85 -36 7 -57 -105 10 -39 -93 34]
@@ -48,3 +46,5 @@ Caused by: com.google.zetasketch.shaded.com.google.protobuf.InvalidProtocolBuffe
4846
The problem seems to be the leading "0" in DATA1: `0 0 0 0 0 0 0 0`
4947

5048
similar issues on the web: https://github.com/quarkusio/quarkus/issues/35125
49+
50+
**TO FIX THIS ERROR SEE use [reflect-config.json](./resources/META-INF/native-image/com.google/zetasketch/reflect-config.json)**

zetasketch/project.clj

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"--verbose"
2424
"--no-fallback"
2525
"--report-unsupported-elements-at-runtime"
26-
"--initialize-at-build-time=clojure,simple,com.google.zetasketch,com.google.protos.zetasketch"
26+
"--initialize-at-build-time=clojure,simple"
2727
"-jar" "./target/${:uberjar-name:-${:name}-${:version}-standalone.jar}"
2828
"-H:Name=./target/${:name}"]
2929

0 commit comments

Comments
 (0)