Introduce and satisfy Eastwood

Fixes #19

Author: vemv

deps.edn

@@ -38,4 +38,10 @@
            ;; build a jar, https://juxt.pro/blog/posts/pack-maven.html
            :pack {:extra-deps {pack/pack.alpha {:git/url "https://github.com/juxt/pack.alpha.git"
                                                 :sha "2769a6224bfb938e777906ea311b3daf7d2220f5"}}
-                  :main-opts ["-m"]}}}
+                  :main-opts ["-m"]}
+
+           ;; clojure -M:dev-figwheel:fig-repl:dev-shadow:test:eastwood
+           :eastwood
+           {:main-opts ["-m" "eastwood.lint" {:config-files ["eastwood.clj"]}]
+            :extra-deps {org.clojure/tools.nrepl {:mvn/version "0.2.13"}
+                         jonase/eastwood {:mvn/version "0.9.9"}}}}}

eastwood.clj

@@ -0,0 +1,6 @@
+;; avoid a corner case in Eastwood / tools.analyzer:
+(require 'figwheel.main.api)
+
+(disable-warning
+ {:linter :constant-test
+  :if-inside-macroexpansion-of #{'suitable.complete-for-nrepl/with-cljs-env}})

src/dev/suitable/scratch.clj

@@ -1,4 +1,4 @@
-(ns dev.suitable.scratch
+(ns suitable.scratch
   (:require [clojure.zip :as zip]
             [clojure.spec.alpha :as s]
             [clojure.spec.test.alpha :as st]))

src/main/suitable/complete_for_nrepl.clj

@@ -110,7 +110,7 @@
   `cider.piggieback/generate-delegating-repl-env`."
   [renv]
   (= (some-> 'cljs.repl.node.NodeEnv
-             resolve
+             ^Class (resolve)
              .getName
              (string/replace "." "_"))
      (-> renv

src/main/suitable/js_completions.cljc

@@ -25,8 +25,9 @@
        (cljs-eval-fn ns code))
      (catch #?(:clj Exception :cljs js/Error) e {:error e}))))
 
-(defn find-prefix [form]
+(defn find-prefix
   "Tree search for the symbol '__prefix. Returns a zipper."
+  [form]
   (loop [node (tree-zipper form)]
     (if (= '__prefix__ (zip/node node))
       node
@@ -131,7 +132,6 @@
           ;; or "(this-as this this)" for symbol = "js/window"
           obj-expr (cl-format nil "(this-as this ~[this~:;(.. this ~{-~A~^ ~})~])"
                               (count obj-expr-parts) obj-expr-parts)]
-      obj-expr-parts
       {:prefix prefix
        :prepend-to-candidate (str "js/" dotted-obj-expr)
        :vars-have-dashes? false

src/main/suitable/utils.clj

@@ -1,5 +1,7 @@
 (ns suitable.utils
-  (:require cljs.env ))
+  (:require
+   [cljs.env]
+   [cljs.repl]))
 
 (defn wrapped-cljs-repl-eval
   "cljs-eval-fn for `suitable.cljs-completions` that can be used when a

src/test/suitable/complete_for_nrepl_test.clj

@@ -9,8 +9,8 @@
 (def ^:dynamic *handler* cider-nrepl-handler)
 (def ^:dynamic *session* nil)
 
-(def ^:dynamic *server* nil)
-(def ^:dynamic *transport* nil)
+(def ^:dynamic ^nrepl.server.Server *server* nil)
+(def ^:dynamic ^nrepl.transport.FnTransport *transport* nil)
 
 (defn message
   ([msg] (message msg true))
@@ -20,14 +20,20 @@
        (nrepl/combine-responses responses)
        responses))))
 
+(def handler nil)
+(def server nil)
+(def transport nil)
+(def client nil)
+(def session nil)
+
 (defmacro start [renv-form]
   `(do
-     (def handler (default-handler #'piggieback/wrap-cljs-repl #'wrap-complete-standalone))
-     (def server    (start-server :handler handler))
-     (def transport (nrepl/connect :port (:port server)))
-     (def client  (nrepl/client transport 3000))
-     (def session (nrepl/client-session client))
-     (alter-var-root #'*server*    (constantly server))
+     (alter-var-root #'handler (constantly (default-handler #'piggieback/wrap-cljs-repl #'wrap-complete-standalone)))
+     (alter-var-root #'server (constantly (start-server :handler handler)))
+     (alter-var-root #'transport (constantly (nrepl/connect :port (:port server))))
+     (alter-var-root #'client (constantly (nrepl/client transport 3000)))
+     (alter-var-root #'session (constantly (nrepl/client-session client)))
+     (alter-var-root #'*server* (constantly server))
      (alter-var-root #'*transport* (constantly transport))
      (alter-var-root #'*session* (constantly session))
      (dorun (message

src/test/suitable/js_completion_test.clj

@@ -174,7 +174,7 @@
            (sut/cljs-completions cljs-eval-fn "ba" {:ns "cljs.user" :context "(.. js/foo zork (__prefix__ \"foo\"))"})))))
 
 
-(deftest dotdot-completion-chained+nested
+(deftest dotdot-completion-chained+nested-2
   (let [cljs-eval-fn (fake-cljs-eval-fn "(.. js/foo zork)" "ba" [{:name "bar" :hierarchy 1 :type "var"}
                                                         {:name "baz" :hierarchy 1 :type "function"}])]
     (is (= [(candidate "-bar" "(.. js/foo zork)")]