Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect syntax highlighting for test name defined with deftest #633

Closed
rrudakov opened this issue Sep 5, 2022 · 4 comments · Fixed by #634
Closed

Incorrect syntax highlighting for test name defined with deftest #633

rrudakov opened this issue Sep 5, 2022 · 4 comments · Fixed by #634

Comments

@rrudakov
Copy link

rrudakov commented Sep 5, 2022

Expected behavior

Test name highlighted with proper face (probably font-lock-function-name-face). I guess it can be related to #630

Actual behavior

Test name highlighted with default face.

Screenshot 2022-09-05 at 11 16 04

Steps to reproduce the problem

  • create test namespace
  • type (deftest some-test)

Environment & Version information

clojure-mode version

clojure-mode (version nil) ;; I guess this is another issue with the package

MELPA package version: clojure-mode 20220903.932

Emacs version

GNU Emacs 29.0.50 (build 1, aarch64-apple-darwin21.6.0, NS appkit-2113.60 Version 12.5.1 (Build 21G83)) of 2022-08-26

Operating system

MacOS

@bbatsov
Copy link
Member

bbatsov commented Sep 5, 2022

@OknoLombarda can you take a look at this?

@rrudakov
Copy link
Author

rrudakov commented Sep 5, 2022

I've just noticed that it's also applicable to defmulti and defmethod:
image

@OknoLombarda
Copy link
Contributor

OknoLombarda commented Sep 5, 2022

Well, it's expected. Only defn now has special highlighting. I'll add defn-, defmulti, defmethod, deftest and deftest- to the list. I think that's all the definitions which define functions? Or should defmacro and definline be highlighted as function definitions, too?

@bbatsov
Copy link
Member

bbatsov commented Sep 5, 2022

We can have all of them with the same font-locking for now. I think that's how most Lisp major modes do it as.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants