Skip to content

Commit 89b4c19

Browse files
authored
Merge pull request #115 from clojure/cljs-3338/coverage-glib-resolve
CLJS-3338: Missing test coverage
2 parents 8ed20cc + f49d377 commit 89b4c19

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

Diff for: src/test/clojure/cljs/analyzer/glib_module_test.clj

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@
4949
'[(ns foo.core
5050
(:import [goog.module ModuleLoader]))])
5151
aenv (assoc (ana/empty-env) :ns (ana/get-namespace cenv 'foo.core))]
52-
(is (= '{:name foo.core.goog$module$goog$module$ModuleLoader
53-
:ns goog.module ;; a bit odd, but doesn't matter, for emission we just :name
52+
(is (= '{:name foo.core/goog$module$goog$module$ModuleLoader
53+
:ns foo.core
5454
:op :var}
5555
(env/with-compiler-env cenv
5656
(ana/resolve-var aenv 'ModuleLoader)))))))

Diff for: src/test/clojure/cljs/test_runner.clj

+8
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,19 @@
11
(ns cljs.test-runner
22
(:require [cljs.analyzer-api-tests]
3+
[cljs.analyzer-pass-tests]
34
[cljs.analyzer-tests]
45
[cljs.build-api-tests]
56
[cljs.closure-tests]
67
[cljs.compiler-tests]
8+
[cljs.compiler.glib-module-test]
79
[cljs.externs-infer-tests]
810
[cljs.externs-parsing-tests]
911
[cljs.instant-tests]
12+
[cljs.js-deps-tests]
1013
[cljs.module-graph-tests]
1114
[cljs.module-processing-tests]
1215
[cljs.source-map.base64-tests]
16+
[cljs.transpile-tests]
1317
[cljs.type-inference-tests]
1418
[cljs.util-tests]
1519
[clojure.test :refer [run-tests]]))
@@ -18,16 +22,20 @@
1822
(let [{:keys [fail error]}
1923
(run-tests
2024
'cljs.analyzer-api-tests
25+
'cljs.analyzer-pass-tests
2126
'cljs.analyzer-tests
2227
'cljs.build-api-tests
2328
'cljs.closure-tests
2429
'cljs.compiler-tests
30+
'cljs.compiler.glib-module-test
2531
'cljs.externs-infer-tests
2632
'cljs.externs-parsing-tests
2733
'cljs.instant-tests
34+
'cljs.js-deps-tests
2835
'cljs.module-graph-tests
2936
'cljs.module-processing-tests
3037
'cljs.source-map.base64-tests
38+
'cljs.transpile-tests
3139
'cljs.type-inference-tests
3240
'cljs.util-tests)]
3341
(if (or (not (zero? fail))

0 commit comments

Comments
 (0)