Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic credentials is triggered too easily #62

Open
1 task
pburkholder opened this issue Feb 9, 2022 · 0 comments
Open
1 task

Generic credentials is triggered too easily #62

pburkholder opened this issue Feb 9, 2022 · 0 comments

Comments

@pburkholder
Copy link
Contributor

In order to avoid false positives, commits like adding cg-scripts/log4j*files should not trigger the Generic Credentials rules:

Here's sample output:

INFO[0000] opening .
{
	"line": "csvwriter.writerow([\"Path\",\"Node_0\",\"Instance_GUID\",\"Customer_Path\",\"Plugin_URLS\",\"App_GUID\",\"App_Name\",\"Space_Name\",\"Org_Name\",\"Org_Managers\",\"Space_Devs\"])",
	"lineNumber": 2,
	"offender": "GUID\",\"Customer_Path\",\"Plugin_URLS\",\"App_GUID\",\"App_Name\",\"Space_Name\",\"Org_Name\",\"Org_Managers\",\"Space_Devs\"",
	"offenderEntropy": -1,
	"commit": "0000000000000000000000000000000000000000",
	"repo": "cg-scripts",
	"repoURL": "",
	"leakURL": "",
	"rule": "Generic Credential",
	"commitMessage": "",
	"author": "",
	"email": "",
	"file": "audit/log4j-nessus-parser.py",
	"date": "1970-01-01T00:00:00Z",
	"tags": "key, API, generic"
}
{
	"line": "app_guid_file = open(\"app_guids\", \"r\")",
	"lineNumber": 2,
	"offender": "guid_file = open(\"app_guids\"",
	"offenderEntropy": -1,
	"commit": "0000000000000000000000000000000000000000",
	"repo": "cg-scripts",
	"repoURL": "",
	"leakURL": "",
	"rule": "Generic Credential",
	"commitMessage": "",
	"author": "",
	"email": "",
	"file": "audit/log4j-report-users.py",
	"date": "1970-01-01T00:00:00Z",
	"tags": "key, API, generic"
}

Acceptance Criteria

  • GIVEN a commit with the cg-scripts/audit/log4j* files,
    THEN no findings

Security considerations

Reducing false positives supports use of this tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant