chore: bump vhost version from 0.6.0 to 0.11.0 and prepare for v0.12.1 release

- Follow the RUSTSEC-2024-0002 advisory by bumping the vhost version from 0.6.0 to 0.11.0.
- Add the `unexpected-cfgs` flag to address the Clippy error related to the `async_io` feature.
- Keep the vm-memory version consistent with the updated vhost version.
- Prepare for the release of v0.12.1.

Signed-off-by: Yang Kaiyong <[email protected]>

Author: BraveY

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "fuse-backend-rs"
-version = "0.12.0"
+version = "0.12.1"
 keywords = ["fuse", "virtio", "virtio-fs", "vhost-user-fs"]
 categories = ["filesystem", "os::linux-apis"]
 description = "A rust library for Fuse(filesystem in userspace) servers and virtio-fs devices"
@@ -20,7 +20,7 @@ build = "build.rs"
 arc-swap = "1.5"
 async-trait = { version = "0.1.42", optional = true }
 bitflags = "1.1"
-dbs-snapshot = { version = "1.5.0", optional = true }
+dbs-snapshot = { version = "1.5.2", optional = true }
 io-uring = { version = "0.5.8", optional = true }
 lazy_static = "1.4"
 libc = "0.2.68"
@@ -31,11 +31,11 @@ radix_trie = "0.2.1"
 tokio = { version = "1", optional = true }
 tokio-uring = { version = "0.4.0", optional = true }
 vmm-sys-util = { version = "0.12.1", optional = true }
-vm-memory = { version = "0.16.1", features = ["backend-mmap"] }
-virtio-queue = { version = "0.14.0", optional = true }
-vhost = { version = "0.6", features = ["vhost-user-slave"], optional = true }
+vm-memory = { version = "0.14.1", features = ["backend-mmap"] }
+virtio-queue = { version = "0.12.0", optional = true }
+vhost = { version = "0.11.0", features = ["vhost-user","vhost-user-backend"], optional = true }
 versionize_derive = { version = "0.1.6", optional = true }
-versionize = { version = "0.1.10", optional = true }
+versionize = { version = "0.2.0", optional = true }
 
 [target.'cfg(target_os = "macos")'.dependencies]
 core-foundation-sys = { version = ">=0.8", optional = true }
@@ -46,8 +46,8 @@ tokio-uring = { version = "0.4.0", optional = true }
 
 [dev-dependencies]
 tokio-test = "0.4.2"
-vmm-sys-util = "0.12.0"
-vm-memory = { version = "0.16.1", features = ["backend-mmap", "backend-bitmap"] }
+vmm-sys-util = "0.12.1"
+vm-memory = { version = "0.14.1", features = ["backend-mmap", "backend-bitmap"] }
 
 [features]
 default = ["fusedev"]
@@ -66,7 +66,6 @@ virtiofs = ["virtio-queue", "caps", "vmm-sys-util"]
 vhost-user-fs = ["virtiofs", "vhost", "caps"]
 persist = ["dbs-snapshot", "versionize", "versionize_derive"]
 fuse-t = []
-async_io = []
 
 [package.metadata.docs.rs]
 all-features = true
@@ -75,6 +74,3 @@ targets = [
     "aarch64-unknown-linux-gnu",
     "aarch64-apple-darwin",
 ]
-
-[lints.rust]
-unexpected_cfgs = { level = "warn", check-cfg = ['cfg(testff)'] }

src/abi/fuse_abi_linux.rs

@@ -1322,6 +1322,7 @@ unsafe impl ByteValued for CopyFileRangeIn {}
 
 #[cfg(test)]
 mod tests {
+
     use super::*;
 
     #[test]
@@ -1346,7 +1347,12 @@ mod tests {
         let buf = [
             0x1u8, 0x2u8, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x5u8, 0x6u8, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
         ];
-        let forget: &ForgetOne = ForgetOne::from_slice(&buf).unwrap();
+        let forget = match ForgetOne::from_slice(&buf) {
+            Some(f) => f,
+            None => {
+                panic!("Failed to parse ForgetOne from buffer: {:?}", buf)
+            }
+        };
 
         assert_eq!(forget.nodeid, 0x201u64);
         assert_eq!(forget.nlookup, 0x605u64);

src/abi/fuse_abi_macos.rs

@@ -1090,7 +1090,12 @@ mod tests {
         let buf = [
             0x1u8, 0x2u8, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x5u8, 0x6u8, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
         ];
-        let forget: &ForgetOne = ForgetOne::from_slice(&buf).unwrap();
+        let forget = match ForgetOne::from_slice(&buf) {
+            Some(f) => f,
+            None => {
+                panic!("Failed to parse ForgetOne from buffer: {:?}", buf)
+            }
+        };
 
         assert_eq!(forget.nodeid, 0x201u64);
         assert_eq!(forget.nlookup, 0x605u64);

src/common/file_buf.rs

@@ -180,7 +180,8 @@ impl<'a> FileVolatileSlice<'a> {
     }
 }
 
-impl Bytes<usize> for FileVolatileSlice<'_> {
+#[allow(clippy::needless_lifetimes)]
+impl<'a> Bytes<usize> for FileVolatileSlice<'a> {
     type E = VError;
 
     fn write(&self, buf: &[u8], addr: usize) -> Result<usize, Self::E> {

src/lib.rs

@@ -4,6 +4,7 @@
 // SPDX-License-Identifier: Apache-2.0
 
 #![deny(missing_docs)]
+#![allow(unexpected_cfgs)]
 
 //! A rust library for Fuse(filesystem in userspace) servers and virtio-fs devices.
 //!

src/passthrough/file_handle.rs

@@ -328,7 +328,7 @@ mod tests {
         buf: Vec<libc::c_char>,
     ) -> CFileHandle {
         let mut wrapper = CFileHandle::new(handle_bytes);
-        let fh = wrapper.wrapper.as_mut_fam_struct();
+        let fh = unsafe { wrapper.wrapper.as_mut_fam_struct() };
         fh.handle_type = handle_type;
         unsafe {
             fh.f_handle
@@ -401,7 +401,7 @@ mod tests {
     fn test_c_file_handle_wrapper() {
         let buf = (0..=127).collect::<Vec<libc::c_char>>();
         let mut wrapper = generate_c_file_handle(MAX_HANDLE_SIZE, 3, buf.clone());
-        let fh = wrapper.wrapper.as_mut_fam_struct();
+        let fh = unsafe { wrapper.wrapper.as_mut_fam_struct() };
 
         assert_eq!(fh.handle_bytes as usize, MAX_HANDLE_SIZE);
         assert_eq!(fh.handle_type, 3);

src/transport/fs_cache_req_handler.rs

@@ -16,10 +16,10 @@ mod virtiofs {
 
     #[cfg(feature = "vhost-user-fs")]
     use vhost::vhost_user::message::{
-        VhostUserFSSlaveMsg, VhostUserFSSlaveMsgFlags, VHOST_USER_FS_SLAVE_ENTRIES,
+        VhostUserFSBackendMsg, VhostUserFSBackendMsgFlags, VHOST_USER_FS_BACKEND_ENTRIES,
     };
     #[cfg(feature = "vhost-user-fs")]
-    use vhost::vhost_user::{SlaveFsCacheReq, VhostUserMasterReqHandler};
+    use vhost::vhost_user::{Backend, VhostUserFrontendReqHandler};
 
     use crate::abi::virtio_fs::RemovemappingOne;
     #[cfg(feature = "vhost-user-fs")]
@@ -54,7 +54,7 @@ mod virtiofs {
     }
 
     #[cfg(feature = "vhost-user-fs")]
-    impl FsCacheReqHandler for SlaveFsCacheReq {
+    impl FsCacheReqHandler for Backend {
         fn map(
             &mut self,
             foffset: u64,
@@ -63,31 +63,31 @@ mod virtiofs {
             flags: u64,
             fd: RawFd,
         ) -> io::Result<()> {
-            let mut msg: VhostUserFSSlaveMsg = Default::default();
+            let mut msg: VhostUserFSBackendMsg = Default::default();
             msg.fd_offset[0] = foffset;
             msg.cache_offset[0] = moffset;
             msg.len[0] = len;
             msg.flags[0] = if (flags & SetupmappingFlags::WRITE.bits()) != 0 {
-                VhostUserFSSlaveMsgFlags::MAP_W | VhostUserFSSlaveMsgFlags::MAP_R
+                VhostUserFSBackendMsgFlags::MAP_W | VhostUserFSBackendMsgFlags::MAP_R
             } else {
-                VhostUserFSSlaveMsgFlags::MAP_R
+                VhostUserFSBackendMsgFlags::MAP_R
             };
 
-            self.fs_slave_map(&msg, &fd)?;
+            self.fs_backend_map(&msg, &fd)?;
 
             Ok(())
         }
 
         fn unmap(&mut self, requests: Vec<RemovemappingOne>) -> io::Result<()> {
-            for chunk in requests.chunks(VHOST_USER_FS_SLAVE_ENTRIES) {
-                let mut msg: VhostUserFSSlaveMsg = Default::default();
+            for chunk in requests.chunks(VHOST_USER_FS_BACKEND_ENTRIES) {
+                let mut msg: VhostUserFSBackendMsg = Default::default();
 
                 for (ind, req) in chunk.iter().enumerate() {
                     msg.len[ind] = req.len;
                     msg.cache_offset[ind] = req.moffset;
                 }
 
-                self.fs_slave_unmap(&msg)?;
+                self.fs_backend_unmap(&msg)?;
             }
 
             Ok(())

src/transport/fusedev/fuse_t_session.rs

@@ -416,7 +416,7 @@ fn fuse_kern_mount(
                 cmd.arg("-r");
             }
             cmd.arg(mountpoint);
-            cmd.exec();
+            let _ = cmd.exec();
             panic!("never arrive here")
         }
     }

src/transport/fusedev/macos_session.rs

@@ -395,8 +395,14 @@ fn create_disk(mountpoint: &Path, dasession: DASessionRef) -> DADiskRef {
         let url =
             CFURLCreateWithFileSystemPath(std::ptr::null(), url_str, kCFURLPOSIXPathStyle, 1u8);
         let disk = DADiskCreateFromVolumePath(std::ptr::null(), dasession, url);
-        CFRelease(std::mem::transmute(url_str));
-        CFRelease(std::mem::transmute(url));
+        CFRelease(std::mem::transmute::<
+            *const core_foundation_sys::string::__CFString,
+            *const libc::c_void,
+        >(url_str));
+        CFRelease(std::mem::transmute::<
+            *const core_foundation_sys::url::__CFURL,
+            *const libc::c_void,
+        >(url));
         disk
     }
 }
@@ -419,7 +425,7 @@ fn fuse_kern_umount(file: File, disk: Option<DADiskRef>) -> Result<()> {
                 None,
                 std::ptr::null_mut(),
             );
-            CFRelease(std::mem::transmute(disk));
+            CFRelease(std::mem::transmute::<DADiskRef, *const libc::c_void>(disk));
         }
     }
     Ok(())

src/transport/mod.rs

@@ -797,27 +797,29 @@ mod tests {
     #[test]
     fn test_mark_dirty() {
         let mut buf1 = vec![0x0u8; 16];
-        let bitmap1 = AtomicBitmap::new(16, 2);
+        let bitmap1 = AtomicBitmap::new(16, std::num::NonZero::new(2).unwrap());
 
         assert_eq!(bitmap1.len(), 8);
         for i in 0..8 {
             assert_eq!(bitmap1.is_bit_set(i), false);
         }
 
         let mut buf2 = vec![0x0u8; 16];
-        let bitmap2 = AtomicBitmap::new(16, 2);
+        let bitmap2 = AtomicBitmap::new(16, std::num::NonZero::new(2).unwrap());
         let mut bufs = VecDeque::new();
 
         unsafe {
             bufs.push_back(VolatileSlice::with_bitmap(
                 buf1.as_mut_ptr(),
                 buf1.len(),
                 bitmap1.slice_at(0),
+                None,
             ));
             bufs.push_back(VolatileSlice::with_bitmap(
                 buf2.as_mut_ptr(),
                 buf2.len(),
                 bitmap2.slice_at(0),
+                None,
             ));
         }
         let mut buffers = IoBuffers {