Skip to content

Commit 1d40d83

Browse files
committed
conf: use g_strdupv instead of virStringListCopy
Also remove the temporary variable - even virStringListCopy aborts on OOM now. Signed-off-by: Ján Tomko <[email protected]> Reviewed-by: Martin Kletzander <[email protected]>
1 parent d339113 commit 1d40d83

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

src/conf/domain_capabilities.c

+1-5
Original file line numberDiff line numberDiff line change
@@ -199,14 +199,10 @@ virDomainCapsCPUModelsAdd(virDomainCapsCPUModelsPtr cpuModels,
199199
char **blockers)
200200
{
201201
g_autofree char * nameCopy = NULL;
202-
VIR_AUTOSTRINGLIST blockersCopy = NULL;
203202
virDomainCapsCPUModelPtr cpu;
204203

205204
nameCopy = g_strdup(name);
206205

207-
if (virStringListCopy(&blockersCopy, (const char **)blockers) < 0)
208-
return -1;
209-
210206
if (VIR_RESIZE_N(cpuModels->models, cpuModels->nmodels_max,
211207
cpuModels->nmodels, 1) < 0)
212208
return -1;
@@ -216,7 +212,7 @@ virDomainCapsCPUModelsAdd(virDomainCapsCPUModelsPtr cpuModels,
216212

217213
cpu->usable = usable;
218214
cpu->name = g_steal_pointer(&nameCopy);
219-
cpu->blockers = g_steal_pointer(&blockersCopy);
215+
cpu->blockers = g_strdupv(blockers);
220216

221217
return 0;
222218
}

0 commit comments

Comments
 (0)