Skip to content

Commit 24b2f96

Browse files
committed
tools: remove unnecessary includes
After the split of virsh to multiple files, and the subsequent split to vsh/virt-admin, there are quite a few leftovers. Signed-off-by: Ján Tomko <[email protected]> Reviewed-by: Martin Kletzander <[email protected]>
1 parent 59ab98c commit 24b2f96

20 files changed

+7
-38
lines changed

tools/virsh-domain-monitor.c

-2
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@
2323
#include "virsh-util.h"
2424

2525
#include <libxml/parser.h>
26-
#include <libxml/tree.h>
2726
#include <libxml/xpath.h>
28-
#include <libxml/xmlsave.h>
2927

3028
#include "internal.h"
3129
#include "conf/virdomainobjlist.h"

tools/virsh-domain.c

-4
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,9 @@
2424

2525
#include <fcntl.h>
2626
#include <signal.h>
27-
#include <sys/time.h>
2827

2928
#include <libxml/parser.h>
30-
#include <libxml/tree.h>
3129
#include <libxml/xpath.h>
32-
#include <libxml/xmlsave.h>
3330

3431
#include "internal.h"
3532
#include "virbitmap.h"
@@ -50,7 +47,6 @@
5047
#include "virtime.h"
5148
#include "virtypedparam.h"
5249
#include "virxml.h"
53-
#include "virsh-nodedev.h"
5450
#include "viruri.h"
5551
#include "vsh-table.h"
5652
#include "virenum.h"

tools/virsh-host.c

+1-4
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,15 @@
2020

2121
#include <config.h>
2222
#include "virsh-host.h"
23+
#include "virsh.h"
2324

2425
#include <libxml/parser.h>
25-
#include <libxml/tree.h>
2626
#include <libxml/xpath.h>
27-
#include <libxml/xmlsave.h>
2827

2928
#include "internal.h"
3029
#include "virbitmap.h"
31-
#include "virbuffer.h"
3230
#include "viralloc.h"
3331
#include "virxml.h"
34-
#include "virtypedparam.h"
3532
#include "virstring.h"
3633
#include "virfile.h"
3734
#include "virenum.h"

tools/virsh-host.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@
2020

2121
#pragma once
2222

23-
#include "virsh.h"
23+
#include "vsh.h"
2424

2525
extern const vshCmdDef hostAndHypervisorCmds[];

tools/virsh-interface.c

-4
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,13 @@
3131
#include "virsh-interface.h"
3232

3333
#include <libxml/parser.h>
34-
#include <libxml/tree.h>
3534
#include <libxml/xpath.h>
36-
#include <libxml/xmlsave.h>
3735

3836
#include "internal.h"
39-
#include "virbuffer.h"
4037
#include "viralloc.h"
4138
#include "virfile.h"
4239
#include "virmacaddr.h"
4340
#include "virxml.h"
44-
#include "virstring.h"
4541
#include "vsh-table.h"
4642

4743
virInterfacePtr

tools/virsh-network.c

-2
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,8 @@
2222
#include "virsh-network.h"
2323

2424
#include "internal.h"
25-
#include "virbuffer.h"
2625
#include "viralloc.h"
2726
#include "virfile.h"
28-
#include "virstring.h"
2927
#include "virtime.h"
3028
#include "conf/network_conf.h"
3129
#include "vsh-table.h"

tools/virsh-nodedev.c

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
#include "virsh-nodedev.h"
2323

2424
#include "internal.h"
25-
#include "virbuffer.h"
2625
#include "viralloc.h"
2726
#include "virfile.h"
2827
#include "virstring.h"

tools/virsh-nwfilter.c

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
#include "virsh-nwfilter.h"
2323

2424
#include "internal.h"
25-
#include "virbuffer.h"
2625
#include "viralloc.h"
2726
#include "virfile.h"
2827
#include "vsh-table.h"

tools/virsh-secret.c

-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
#include "virfile.h"
2929
#include "virutil.h"
3030
#include "virsecret.h"
31-
#include "virstring.h"
3231
#include "virtime.h"
3332
#include "vsh-table.h"
3433
#include "virenum.h"

tools/virsh-secret.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
#pragma once
2222

23-
#include "virsh.h"
23+
#include "vsh.h"
2424

2525
struct virshSecretEventCallback {
2626
const char *name;

tools/virsh-snapshot.c

-2
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@
2424
#include <assert.h>
2525

2626
#include <libxml/parser.h>
27-
#include <libxml/tree.h>
2827
#include <libxml/xpath.h>
29-
#include <libxml/xmlsave.h>
3028

3129
#include "internal.h"
3230
#include "virbuffer.h"

tools/virsh-snapshot.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@
2020

2121
#pragma once
2222

23-
#include "virsh.h"
23+
#include "vsh.h"
2424

2525
extern const vshCmdDef snapshotCmds[];

tools/virsh-volume.c

-2
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@
2525
#include <fcntl.h>
2626

2727
#include <libxml/parser.h>
28-
#include <libxml/tree.h>
2928
#include <libxml/xpath.h>
30-
#include <libxml/xmlsave.h>
3129

3230
#include "internal.h"
3331
#include "virbuffer.h"

tools/virsh.h

-2
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@
2020

2121
#pragma once
2222

23-
#include <stdarg.h>
2423
#include <unistd.h>
25-
#include <sys/stat.h>
2624

2725
#include "internal.h"
2826
#include "virerror.h"

tools/virt-admin-completer.c

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
#include "internal.h"
2525
#include "virt-admin.h"
2626
#include "viralloc.h"
27-
#include "virstring.h"
2827

2928

3029
char **

tools/virt-admin.c

+3-1
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,9 @@
1919
*/
2020

2121
#include <config.h>
22-
#include "virt-admin.h"
2322

23+
#include <stdio.h>
24+
#include <unistd.h>
2425
#include <getopt.h>
2526

2627
#if WITH_READLINE
@@ -29,6 +30,7 @@
2930
#endif
3031

3132
#include "internal.h"
33+
#include "virt-admin.h"
3234
#include "viralloc.h"
3335
#include "virerror.h"
3436
#include "virfile.h"

tools/virt-host-validate-qemu.c

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
*/
2121

2222
#include <config.h>
23-
#include <unistd.h>
2423

2524
#include "virt-host-validate-qemu.h"
2625
#include "virt-host-validate-common.h"

tools/vsh-table.c

-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@
2828

2929
#include "viralloc.h"
3030
#include "virbuffer.h"
31-
#include "virstring.h"
32-
#include "virsh-util.h"
3331

3432
#define HEX_ENCODE_LENGTH 4 /* represents length of '\xNN' */
3533

tools/vsh.c

-3
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@
2424
#include <assert.h>
2525
#include <stdarg.h>
2626
#include <unistd.h>
27-
#include <sys/time.h>
2827
#include <fcntl.h>
29-
#include <time.h>
3028
#include <sys/stat.h>
3129
#include <inttypes.h>
3230
#include <signal.h>
@@ -42,7 +40,6 @@
4240
#include "virfile.h"
4341
#include "virthread.h"
4442
#include "vircommand.h"
45-
#include "virtypedparam.h"
4643
#include "virstring.h"
4744
#include "virutil.h"
4845

tools/vsh.h

-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121
#pragma once
2222

2323
#include <stdarg.h>
24-
#include <unistd.h>
25-
#include <sys/stat.h>
2624
#ifndef WIN32
2725
# include <termios.h>
2826
#endif

0 commit comments

Comments
 (0)