Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pure-sasl only (including in linux) #36

Open
antoniivanov opened this issue Apr 23, 2021 · 6 comments
Open

Use pure-sasl only (including in linux) #36

antoniivanov opened this issue Apr 23, 2021 · 6 comments

Comments

@antoniivanov
Copy link

Hi,

I am wondering why are we not using pure-sasl on linux as well - https://github.com/cloudera/thrift_sasl/blob/master/setup.py#L36

sasl is pretty hard to install on linux. especially in environment we have not control over - e.g docker or client environment. So so it will be much easier if we can use pure-sasl, right?

Is there reason thrift-sasl depends on sasl for linux ?

@potiuk
Copy link

potiuk commented Apr 27, 2021

Hey @attilajeges - quick question, I saw that pure-sasl version released in alpha couple of hours ago. do you have any expectations about the final release date? I believe this is the last blocker for Apache Airlfow to move to Python 3.9 (old sasl library does not support it). I saw also that you prepared alpha release for the sasl version (with py39 binaries). Maybe that one will be faster?

@attilajeges
Copy link

attilajeges commented Apr 28, 2021

Hi @potiuk , we don't have an ETA yet. Currently we are testing this alpha release to see how reliable / robust pure-sasl is. If everything looks good, probably we can have an official release in a couple of weeks. There are no guarantees though.

About the 0.4.3a1 alpha release with sasl wheels: One of our requirements is not to depend on g++, so releasing sasl wheels with a pre-built C++ extension was a first attempt at achieving this goal. The sasl wheels include the pre-built C++ extension and its dependencies, including libsasl2.so. The issue with this is that libsasl2.so is not portable across linux distributions (it uses different paths to find SASL authentication plugins on different OSes). This means that a sasl wheel built in a CentOS-based manylinux docker container will not work on Debian/Ubuntu. Because of this, I'd prefer to drop sasl and use pure-sasl inthrift-sasl instead.

@potiuk
Copy link

potiuk commented Apr 28, 2021

Understood. Thanks. Is there anything I can help with testing of the pure-sasl thrift_sasl? We are using thrift_sasl in our Hive integration in Apache Airflow https://airflow.apache.org/docs/apache-airflow-providers-apache-hive/stable/index.html and sasl is used with kerberos integration and I might either try to make some tests with our test harness with the new version if it is helpful.

In Airflow we have some automated tests with Airflow + Hive Provider + Kerberos + Presto/Trino + Sasl. So this might be pretty helpful I guess ?

@attilajeges
Copy link

@potiuk Thanks, any additional testing would be useful. Your help is appreciated. Note that we already found some minor issues, so there will be a new alpha release soon.

@potiuk
Copy link

potiuk commented Apr 28, 2021

Ok will wait for that and run some testing then.

@attilajeges
Copy link

attilajeges commented Apr 28, 2021

@potiuk Actually, I confused thrift-sasl with impyla (which depends on thrift-sasl). We will have a new alpha release of impyla but thrift-sasl so far looks good. You can go ahead and do some testing with the current alpha 0.4.3a2. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants