complete node:url implementation (#2967)

Author: anonrig

src/node/internal/internal_querystring.ts

@@ -9,7 +9,7 @@ import { ERR_INVALID_URI } from 'node-internal:internal_errors';
 type EncodeFunction = (value: string) => string;
 type DecodeFunction = (value: string) => string;
 
-const hexTable = new Array(256) as string[];
+export const hexTable = new Array(256) as string[];
 for (let i = 0; i < 256; ++i) {
   hexTable[i] = '%' + ((i < 16 ? '0' : '') + i.toString(16)).toUpperCase();
 }
@@ -35,7 +35,7 @@ const isHexTable = new Int8Array([
 ]);
 
 /* eslint-disable */
-function encodeStr(
+export function encodeStr(
   str: string,
   noEscapeTable: Int8Array,
   hexTable: string[]
@@ -339,8 +339,8 @@ function addKeyVal(
 
 export function parse(
   qs: string,
-  sep: string,
-  eq: string,
+  sep?: string,
+  eq?: string,
   options?: {
     maxKeys?: number;
     decodeURIComponent?: DecodeFunction;

src/node/internal/internal_url.ts

@@ -258,3 +258,54 @@ export function toPathIfFileURL(fileURLOrPath: URL | string): string {
   if (!isURL(fileURLOrPath)) return fileURLOrPath;
   return fileURLToPath(fileURLOrPath);
 }
+
+/**
+ * Utility function that converts a URL object into an ordinary options object
+ * as expected by the `http.request` and `https.request` APIs.
+ * @param {URL} url
+ * @returns {Record<string, unknown>}
+ */
+export function urlToHttpOptions(url: URL): Record<string, unknown> {
+  const { hostname, pathname, port, username, password, search } = url;
+  const options: Record<string, unknown> = {
+    __proto__: null,
+    ...url, // In case the url object was extended by the user.
+    protocol: url.protocol,
+    hostname:
+      hostname && hostname[0] === '[' ? hostname.slice(1, -1) : hostname,
+    hash: url.hash,
+    search: search,
+    pathname: pathname,
+    path: `${pathname || ''}${search || ''}`,
+    href: url.href,
+  };
+  if (port !== '') {
+    options.port = Number(port);
+  }
+  if (username || password) {
+    options.auth = `${decodeURIComponent(username)}:${decodeURIComponent(password)}`;
+  }
+  return options;
+}
+
+// Protocols that can allow "unsafe" and "unwise" chars.
+export const unsafeProtocol = new Set<string>(['javascript', 'javascript:']);
+// Protocols that never have a hostname.
+export const hostlessProtocol = new Set<string>(['javascript', 'javascript:']);
+// Protocols that always contain a // bit.
+export const slashedProtocol = new Set<string>([
+  'http',
+  'http:',
+  'https',
+  'https:',
+  'ftp',
+  'ftp:',
+  'gopher',
+  'gopher:',
+  'file',
+  'file:',
+  'ws',
+  'ws:',
+  'wss',
+  'wss:',
+]);