Skip to content

Commit e83592a

Browse files
harrishancockfhanau
authored andcommitted
Revert "Update WPT to 818762709 (#3667)"
This reverts commit 891394c. This update caused downstream test failures which we need to address.
1 parent f7688f6 commit e83592a

File tree

4 files changed

+9
-52
lines changed

4 files changed

+9
-52
lines changed

build/deps/build_deps.jsonc

+1-1
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@
241241
"repo": "workerd-tools",
242242
"file_regex": "wpt-.*.tar.gz",
243243
"build_file": "//:build/BUILD.wpt",
244-
"freeze_version": "wpt-818762709"
244+
"freeze_version": "wpt-af83b77e2"
245245
}
246246
]
247247
}

build/deps/gen/dep_wpt.bzl

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
load("@//:build/http.bzl", "http_archive")
44

5-
TAG_NAME = "wpt-818762709"
6-
URL = "https://github.com/cloudflare/workerd-tools/releases/download/wpt-818762709/wpt-818762709.tar.gz"
7-
STRIP_PREFIX = "wpt-818762709"
8-
SHA256 = "c93305fb0cbd84e20fa329c2ab2e417dbb2456ba1fe521ee35e07f5f4b191341"
5+
TAG_NAME = "wpt-af83b77e2"
6+
URL = "https://github.com/cloudflare/workerd-tools/releases/download/wpt-af83b77e2/wpt-af83b77e2.tar.gz"
7+
STRIP_PREFIX = "wpt-af83b77e2"
8+
SHA256 = "ce7f09bc8ab6604362897c484a1ee044afd7254741e3cecd7cf609d93d779d51"
99
TYPE = "tgz"
1010

1111
def dep_wpt():

src/wpt/url-test.ts

+4-38
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,7 @@
55
import { type TestRunnerConfig } from 'harness/harness';
66

77
export default {
8-
'IdnaTestV2-removed.window.js': {},
9-
'IdnaTestV2.window.js': {
10-
comment:
11-
'WPT recently updated this test to check for Unicode 16 compliance',
12-
// We now have a huge number of failures
13-
// https://github.com/web-platform-tests/wpt/commit/d0cd7c05f70f6928234e90ddff90b39ef9c1eebc
14-
skipAllTests: true,
15-
},
8+
'IdnaTestV2.window.js': {},
169
'historical.any.js': {},
1710
'idlharness.any.js': {
1811
comment: 'Does not contain any relevant tests',
@@ -35,38 +28,17 @@ export default {
3528
},
3629
'toascii.window.js': {
3730
comment:
38-
'Replacer disables tests involving document.createElement. Expected failures are due to Unicode 15.1 and Unicode 16',
31+
'Replacer disables tests involving document.createElement. Expected failures are due to Unicode 15.1',
3932
expectedFailures: [
40-
// Unicode 15.1
4133
// Taken from https://github.com/nodejs/node/blob/5ab7c4c5b01e7579fd436000232f0f0484289d44/test/wpt/status/url.json#L13
4234
'\uD87E\uDC68.com (using URL)',
4335
'\uD87E\uDC68.com (using URL.host)',
4436
'\uD87E\uDC68.com (using URL.hostname)',
45-
// Unicode 16
46-
// https://github.com/web-platform-tests/wpt/commit/12de160159122dc4d0e3ee2d756444b249063e8a
47-
'look\u180Eout.net (using URL)',
48-
'look\u180Eout.net (using URL.host)',
49-
'look\u180Eout.net (using URL.hostname)',
50-
'look\u206Bout.net (using URL)',
51-
'look\u206Bout.net (using URL.host)',
52-
'look\u206Bout.net (using URL.hostname)',
53-
'\u04C0.com (using URL)',
54-
'\u04C0.com (using URL.host)',
55-
'\u04C0.com (using URL.hostname)',
56-
'\u2183.com (using URL)',
57-
'\u2183.com (using URL.host)',
58-
'\u2183.com (using URL.hostname)',
5937
],
6038
replace: (code): string =>
6139
code.replace(/\["url", "a", "area"\]/, '[ "url" ]'),
6240
},
63-
'url-constructor.any.js': {
64-
comment: 'We are expected to encode ^ as %5E',
65-
expectedFailures: [
66-
'Parsing: <foo://host/ !"$%&\'()*+,-./:;<=>@[\\]^_`{|}~> without base',
67-
'Parsing: <wss://host/ !"$%&\'()*+,-./:;<=>@[\\]^_`{|}~> without base',
68-
],
69-
},
41+
'url-constructor.any.js': {},
7042
'url-origin.any.js': {},
7143
'url-searchparams.any.js': {},
7244
'url-setters-a-area.window.js': {
@@ -75,13 +47,7 @@ export default {
7547
skipAllTests: true,
7648
},
7749
'url-setters-stripping.any.js': {},
78-
'url-setters.any.js': {
79-
comment: 'We are expected to encode ^ as %5E',
80-
expectedFailures: [
81-
"URL: Setting <a:/>.pathname = '\x00\x01\t\n" +
82-
"\r\x1F !\"#$%&'()*+,-./09:;<=>?@AZ[\\]^_`az{|}~\x7F\x80\x81Éé' UTF-8 percent encoding with the default encode set. Tabs and newlines are removed.",
83-
],
84-
},
50+
'url-setters.any.js': {},
8551
'url-statics-canparse.any.js': {},
8652
'url-statics-parse.any.js': {},
8753
'url-tojson.any.js': {},

src/wpt/urlpattern-test.ts

-9
Original file line numberDiff line numberDiff line change
@@ -155,15 +155,6 @@ export default {
155155
'Pattern: [{"pathname":"/([[a-z]--a])"}] Inputs: [{"pathname":"/z"}]',
156156
'Pattern: [{"pathname":"/([\\\\d&&[0-1]])"}] Inputs: [{"pathname":"/0"}]',
157157
'Pattern: [{"pathname":"/([\\\\d&&[0-1]])"}] Inputs: [{"pathname":"/3"}]',
158-
'Pattern: ["http://🚲.com/"] Inputs: ["http://🚲.com/"]',
159-
'Pattern: [{"pathname":"\\ud83d \\udeb2"}] Inputs: []',
160-
'Pattern: [{"pathname":"test/:a𐑐b"}] Inputs: [{"pathname":"test/foo"}]',
161-
'Pattern: [{"hostname":"bad#hostname"}] Inputs: undefined',
162-
'Pattern: [{"hostname":"bad%hostname"}] Inputs: undefined',
163-
'Pattern: [{"hostname":"bad/hostname"}] Inputs: undefined',
164-
'Pattern: [{"hostname":"bad\\nhostname"}] Inputs: undefined',
165-
'Pattern: [{"hostname":"bad\\rhostname"}] Inputs: undefined',
166-
'Pattern: [{"hostname":"bad\\thostname"}] Inputs: undefined',
167158
],
168159
},
169160
'urlpattern.https.any.js': {

0 commit comments

Comments
 (0)