fix types eslint config and reenable more strict checks

Author: anonrig

build/wd_ts_project.bzl

@@ -1,15 +1,41 @@
 load("@aspect_rules_ts//ts:defs.bzl", "ts_project")
+load("@npm//:eslint/package_json.bzl", eslint_bin = "bin")
 
-def wd_ts_project(name, srcs, deps, testonly = False):
+def wd_ts_project(name, srcs, deps, eslintrc_json = None, testonly = False):
     """Bazel rule for a workerd TypeScript project, setting common options"""
 
+    tsconfig = "//types:tsconfig.json"
+
     ts_project(
         name = name,
         srcs = srcs,
         deps = deps,
-        tsconfig = "//types:tsconfig.json",
+        tsconfig = tsconfig,
         allow_js = True,
         composite = True,
         source_map = True,
         testonly = testonly,
     )
+
+    if eslintrc_json:
+        eslint_bin.eslint_test(
+            size = "large",
+            name = name + "@eslint",
+            args = [
+                "--config $(location {})".format(eslintrc_json),
+                "--parser-options project:$(location {})".format(tsconfig),
+                "-f stylish",
+                "--report-unused-disable-directives",
+            ] + ["$(location " + src + ")" for src in srcs],
+            data = srcs + deps + [
+                eslintrc_json,
+                tsconfig,
+                "//tools:base-eslint",
+                "//:prettierrc",
+            ],
+            tags = ["lint"],
+            target_compatible_with = select({
+                "@platforms//os:windows": ["@platforms//:incompatible"],
+                "//conditions:default": [],
+            }),
+        )

build/wd_ts_test.bzl

@@ -2,7 +2,7 @@ load("@aspect_rules_js//js:defs.bzl", "js_test")
 load("//:build/typescript.bzl", "js_name", "module_name")
 load("//:build/wd_ts_project.bzl", "wd_ts_project")
 
-def wd_ts_test(src, deps = [], **kwargs):
+def wd_ts_test(src, deps = [], eslintrc_json = None, **kwargs):
     """Bazel rule to compile and run a TypeScript test"""
 
     name = module_name(src)
@@ -12,6 +12,7 @@ def wd_ts_test(src, deps = [], **kwargs):
         srcs = [src],
         deps = deps,
         testonly = True,
+        eslintrc_json = eslintrc_json,
     )
 
     js_test(

package.json

@@ -18,7 +18,6 @@
     "chrome-remote-interface": "^0.33.3",
     "esbuild": "^0.25.0",
     "eslint": "^9.20.1",
-    "eslint-plugin-import": "^2.31.0",
     "expect-type": "^1.1.0",
     "typescript-eslint": "^8.23.0"
   },