Implement node:crypto one-shot hash()

Author: jasnell

src/node/crypto.ts

@@ -45,6 +45,7 @@ import {
   Hash,
   HashOptions,
   Hmac,
+  hash,
 } from 'node-internal:crypto_hash';
 
 import {
@@ -119,6 +120,7 @@ export {
   Hash,
   HashOptions,
   Hmac,
+  hash,
   // Hkdf
   hkdf,
   hkdfSync,
@@ -250,6 +252,7 @@ export default {
   createHash,
   createHmac,
   getHashes,
+  hash,
   // Hkdf
   hkdf,
   hkdfSync,

src/node/internal/crypto_hash.ts

@@ -300,4 +300,29 @@ Hmac.prototype._flush = Hash.prototype._flush;
 // eslint-disable-next-line @typescript-eslint/unbound-method
 Hmac.prototype._transform = Hash.prototype._transform;
 
+export function hash(
+  algorithm: string,
+  data: string | ArrayBufferView,
+  outputEncoding: string = 'hex'
+) {
+  validateString(algorithm, 'algorithm');
+  validateString(outputEncoding, 'outputEncoding');
+
+  if (typeof data === 'string') {
+    const hash = createHash(algorithm);
+    hash.update(data, 'utf8');
+    return hash.digest(outputEncoding);
+  } else if (isArrayBufferView(data)) {
+    const hash = createHash(algorithm);
+    hash.update(data, 'utf8');
+    return hash.digest(outputEncoding);
+  }
+
+  throw new ERR_INVALID_ARG_TYPE(
+    'data',
+    ['string', 'Buffer', 'TypedArray', 'DataView'],
+    data
+  );
+}
+
 export { Hash, Hmac };

src/workerd/api/node/tests/crypto_hash-test.js

@@ -291,3 +291,36 @@ export const hash_pipe_test = {
     await p.promise;
   },
 };
+
+export const hash_one_shot = {
+  test() {
+    const string = 'Node.js';
+    assert.strictEqual(
+      crypto.hash('sha1', 'Node.js'),
+      '10b3493287f831e81a438811a1ffba01f8cec4b7'
+    );
+
+    const check = Buffer.from(
+      '10b3493287f831e81a438811a1ffba01f8cec4b7',
+      'hex'
+    );
+    const base64 = 'Tm9kZS5qcw==';
+    assert.deepStrictEqual(
+      crypto.hash('sha1', Buffer.from(base64, 'base64'), 'buffer'),
+      check
+    );
+
+    assert.throws(() => crypto.hash(1), {
+      code: 'ERR_INVALID_ARG_TYPE',
+    });
+    assert.throws(() => crypto.hash('sha1', 12), {
+      code: 'ERR_INVALID_ARG_TYPE',
+    });
+    assert.throws(() => crypto.hash('sha1', 'test', 123), {
+      code: 'ERR_INVALID_ARG_TYPE',
+    });
+    assert.throws(() => crypto.hash('unknown', 'what'), {
+      message: /Digest method not supported/,
+    });
+  },
+};