Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Platform Tests #2862

Open
5 of 8 tasks
kflansburg opened this issue Oct 8, 2024 · 3 comments · Fixed by #2585
Open
5 of 8 tasks

Web Platform Tests #2862

kflansburg opened this issue Oct 8, 2024 · 3 comments · Fixed by #2585
Assignees

Comments

@kflansburg
Copy link
Contributor

kflansburg commented Oct 8, 2024

@npaun npaun linked a pull request Oct 22, 2024 that will close this issue
@npaun npaun reopened this Oct 22, 2024
@anonrig
Copy link
Member

anonrig commented Oct 30, 2024

@npaun It seems assert_throws_js implementation is wrong. Here's the Node.js implementation: https://github.com/nodejs/node/blob/8807549ed9f6eaf6842ae56b8ac55ab385951636/test/fixtures/wpt/resources/testharness.js#L2046

Completed in #3157

@anonrig
Copy link
Member

anonrig commented Oct 30, 2024

Additional issue: @npaun If a test is in expected_failures but if it doesn't fail, we should also throw an error.

Completed in #3157

@npaun
Copy link
Member

npaun commented Oct 30, 2024

Yep that's an excellent idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants