Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gorouter] Support Prometheus metrics #451

Open
maxmoehl opened this issue Jan 17, 2025 · 1 comment
Open

[gorouter] Support Prometheus metrics #451

maxmoehl opened this issue Jan 17, 2025 · 1 comment

Comments

@maxmoehl
Copy link
Member

Proposed Change

Extend the prometheus endpoint in gorouter to export all metrics which are currently exported only via envelopes v1. There was previous work in #246 (maybe @Benjamintf1 or @stefanlay have something to add here) and I've started a POC at https://github.com/sap-contributions/gorouter/compare/maxmoehl/prom. As you can see the interface provided by the prometheus library is a bit lacking and we would probably need to extend it.

One thing to note is that, if you use the graphite nozzle, tags will not work because those are not supported by the graphite nozzle. The main question I'd like to clarify upfront is whether we keep using that library or simply consume prometheus directly?

Acceptance criteria

As a operator
I can switch envelopes v1 and prometheus on/off independently
So that I can choose the right metric collection approach for my system.

Related links

No response

@maxmoehl
Copy link
Member Author

Regarding the go-metric-registry: Should we:

  1. extend it to cover the use-cases we have for prometheus, or
  2. drop it and consume prometheus directly?

I'm in favour of using prometheus directly primarily because I don't see what the library is abstracting away. There is only this one implementation and the support from the prometheus community seems to be very good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant