Skip to content

Feature Add: Add mTLS support #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChrisMcGowan opened this issue Nov 18, 2022 · 4 comments
Open

Feature Add: Add mTLS support #17

ChrisMcGowan opened this issue Nov 18, 2022 · 4 comments

Comments

@ChrisMcGowan
Copy link

In order to have parity with the linux syslog release, please add support for mTLS to this windows release as it's configured for the linux version.

This is support a mixed diego-cell environment (linux and windows) that utilize syslog and require mTLS.

Thank you

@Benjamintf1
Copy link
Member

Just saw this now. Just a heads up, might want to reach out in the logging and metrics slack if you want people to see this issue. Also, ping me in slack if you make a pr for this, or if you want any advice on making a pr.

Main tests are here https://github.com/cloudfoundry/windows-syslog-release/tree/main/tests, please introduce a new test case like syslog-release if you do, https://github.com/cloudfoundry/syslog-release/blob/49b260be5fe5274e9b9c49c145e5e08095e5528f/tests/acceptance_test.go#L236. Probably also requires a pr to blackbox to enable optional mtls as well.

@MirzaAli-Baig
Copy link

Did we resolve this. Any timelines to it

@Benjamintf1
Copy link
Member

No, I don't see a pr in https://github.com/cloudfoundry/blackbox/pulls. If you would like to submit a pr to make this work, feel free to ping me in the https://cloudfoundry.slack.com/archives/CUW93AF3M cloudfoundry slack in #logging-and-metrics and let me know that you have a pr enabling mtls for windows-syslog-release(/blackbox) and I can probubly give you some pretty quick feedback/possibly merging.

@rkoster rkoster moved this from Inbox to Waiting for Changes | Open for Contribution in Foundational Infrastructure Working Group Feb 16, 2023
@MirzaAli-Baig
Copy link

I am administrator. Can you please fix it and provide release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting for Changes | Open for Contribution
Development

No branches or pull requests

3 participants