Skip to content

Commit 7ebb22e

Browse files
chore(ui): fix story types
1 parent 4743a7e commit 7ebb22e

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

packages/ui-components/src/components/ComboBoxOption/ComboBoxOption.component.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export const ComboBoxOption: React.FC<ComboBoxOptionProps> = ({
5353
children,
5454
disabled = false,
5555
value = "",
56-
label,
56+
label = "",
5757
className = "",
5858
...props
5959
}) => {

packages/ui-components/src/components/StyleProvider/StyleProvider.component.tsx

+3-1
Original file line numberDiff line numberDiff line change
@@ -143,13 +143,15 @@ export const StyleProvider = ({
143143

144144
type StyleProviderStylesWrapper = "head" | "inline" | "shadowRoot"
145145

146+
// NOTE for theme prop: Improve the type and logic to contain only valid themes
147+
146148
export interface StyleProviderProps {
147149
/** The children to render. */
148150
children?: ReactNode
149151
/** What element to render as a wrapper, respectively where to render the StyleProvider. */
150152
stylesWrapper?: StyleProviderStylesWrapper
151153
/** The name of the theme to render. */
152-
theme?: "theme-dark" | "theme-light"
154+
theme?: string
153155
/** The mode of the shadowRoot. Only relevant when `stylesWrapper="shadowRoot"`. */
154156
shadowRootMode?: ShadowRootMode
155157
}

0 commit comments

Comments
 (0)