Skip to content
This repository was archived by the owner on Jan 31, 2021. It is now read-only.

Commit ba92dc8

Browse files
authored
Fix DocumentDB DNS cluster and reader DNS names (#5)
* Fix DocumentDB DNS cluster and reader DNS names * Update README * Use `password` from `local`
1 parent 19fc982 commit ba92dc8

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

Diff for: README.md

+5
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,11 @@ The module provisions the following resources:
5353

5454
## Usage
5555

56+
57+
**IMPORTANT:** The `master` branch is used in `source` just as an example. In your code, do not pin to `master` because there may be breaking changes between releases.
58+
Instead pin to the release tag (e.g. `?ref=tags/x.y.z`) of one of our [latest releases](https://github.com/cloudposse/terraform-aws-codefresh-backing-services/releases).
59+
60+
5661
```hcl
5762
module "codefresh_backing_services" {
5863
source = "git::https://github.com/cloudposse/terraform-aws-codefresh-backing-services.git?ref=master"

Diff for: aurora-postgres.tf

+2-2
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ locals {
6262
}
6363

6464
module "aurora_postgres" {
65-
source = "git::https://github.com/cloudposse/terraform-aws-rds-cluster.git?ref=tags/0.10.0"
65+
source = "git::https://github.com/cloudposse/terraform-aws-rds-cluster.git?ref=tags/0.15.0"
6666
namespace = "${var.namespace}"
6767
stage = "${var.stage}"
6868
name = "${var.name}"
@@ -122,7 +122,7 @@ resource "aws_ssm_parameter" "aurora_postgres_master_username" {
122122
resource "aws_ssm_parameter" "aurora_postgres_master_password" {
123123
count = "${local.postgres_cluster_enabled == "true" ? 1 : 0}"
124124
name = "${format(var.chamber_format, local.chamber_service, "aurora_postgres_master_password")}"
125-
value = "${module.aurora_postgres.password}"
125+
value = "${local.postgres_admin_password}"
126126
description = "Aurora Postgres Password for the master DB user"
127127
type = "SecureString"
128128
key_id = "${data.aws_kms_key.chamber_kms_key.id}"

Diff for: documentdb.tf

+3-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ locals {
9797
}
9898

9999
module "documentdb_cluster" {
100-
source = "git::https://github.com/cloudposse/terraform-aws-documentdb-cluster.git?ref=tags/0.1.0"
100+
source = "git::https://github.com/cloudposse/terraform-aws-documentdb-cluster.git?ref=tags/0.2.0"
101101
enabled = "${local.documentdb_cluster_enabled}"
102102
namespace = "${var.namespace}"
103103
stage = "${var.stage}"
@@ -113,6 +113,8 @@ module "documentdb_cluster" {
113113
vpc_id = "${var.vpc_id}"
114114
subnet_ids = ["${var.subnet_ids}"]
115115
zone_id = "${local.zone_id}"
116+
cluster_dns_name = "docdb-master.${var.name}"
117+
reader_dns_name = "docdb-replicas.${var.name}"
116118
allowed_security_groups = ["${var.security_groups}"]
117119
apply_immediately = "${var.documentdb_apply_immediately}"
118120
enabled_cloudwatch_logs_exports = ["${var.documentdb_enabled_cloudwatch_logs_exports}"]

0 commit comments

Comments
 (0)