Fix: fix incorrect conditional logic for dynamic blocks iterating on var.ec2_tag_set and var.ec2_tag_filter (#13)

- Swap second and third arguments in ternary operator for `var.ec2_tag_set` and `var.ec2_tag_filter`, which are incorrectly supplying an empty list if their lengths are > 0.
- Use `lookup` function in dynamic blocks in order to introduce more robustness.

Co-authored-by: nitrocode <[email protected]>
Co-authored-by: cloudpossebot <[email protected]>
Co-authored-by: Yonatan Koren <[email protected]>

Author: 4 people

main.tf

@@ -178,26 +178,27 @@ resource "aws_codedeploy_deployment_group" "default" {
   # Note that you cannot have both ec_tag_filter and ec2_tag_set vars set!
   # See https://docs.aws.amazon.com/cli/latest/reference/deploy/create-deployment-group.html for details
   dynamic "ec2_tag_filter" {
-    for_each = length(var.ec2_tag_filter) > 0 ? [] : var.ec2_tag_filter
+    for_each = length(var.ec2_tag_filter) > 0 ? var.ec2_tag_filter : []
+
     content {
-      key   = ec2_tag_filter.value["key"]
-      type  = ec2_tag_filter.value["type"]
-      value = ec2_tag_filter.value["value"]
+      key   = lookup(ec2_tag_filter.value, "key", null)
+      type  = lookup(ec2_tag_filter.value, "type", null)
+      value = lookup(ec2_tag_filter.value, "value", null)
     }
   }
 
   # Note that you cannot have both ec_tag_filter and ec2_tag_set vars set!
   # See https://docs.aws.amazon.com/cli/latest/reference/deploy/create-deployment-group.html for details
   dynamic "ec2_tag_set" {
-    for_each = length(var.ec2_tag_set) > 0 ? [] : var.ec2_tag_set
+    for_each = length(var.ec2_tag_set) > 0 ? var.ec2_tag_set : []
 
     content {
       dynamic "ec2_tag_filter" {
         for_each = ec2_tag_set.value.ec2_tag_filter
         content {
-          key   = ec2_tag_filter.value["key"]
-          type  = ec2_tag_filter.value["type"]
-          value = ec2_tag_filter.value["value"]
+          key   = lookup(ec2_tag_filter.value, "key", null)
+          type  = lookup(ec2_tag_filter.value, "type", null)
+          value = lookup(ec2_tag_filter.value, "value", null)
         }
       }
     }