From 03446eb48b322431d2a6ecb373756d2b4f8ee481 Mon Sep 17 00:00:00 2001 From: "Aleksey @soar Smyrnov" Date: Fri, 12 Jul 2024 23:16:16 -0230 Subject: [PATCH] fix: Typo in pull-through-access variable --- README.md | 2 +- docs/terraform.md | 2 +- main.tf | 6 +++--- variables.tf | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 7c419b7..75d7068 100644 --- a/README.md +++ b/README.md @@ -180,7 +180,7 @@ Available targets: | [prefixes\_pull\_through\_repositories](#input\_prefixes\_pull\_through\_repositories) | Organization IDs to provide with push access to the ECR | `list(string)` | `[]` | no | | [principals\_full\_access](#input\_principals\_full\_access) | Principal ARNs to provide with full access to the ECR | `list(string)` | `[]` | no | | [principals\_lambda](#input\_principals\_lambda) | Principal account IDs of Lambdas allowed to consume ECR | `list(string)` | `[]` | no | -| [principals\_pull\_though\_access](#input\_principals\_pull\_though\_access) | Principal ARNs to provide with pull though access to the ECR | `list(string)` | `[]` | no | +| [principals\_pull\_through\_access](#input\_principals\_pull\_through\_access) | Principal ARNs to provide with pull through access to the ECR | `list(string)` | `[]` | no | | [principals\_push\_access](#input\_principals\_push\_access) | Principal ARNs to provide with push access to the ECR | `list(string)` | `[]` | no | | [principals\_readonly\_access](#input\_principals\_readonly\_access) | Principal ARNs to provide with readonly access to the ECR | `list(string)` | `[]` | no | | [protected\_tags](#input\_protected\_tags) | Name of image tags prefixes that should not be destroyed. Useful if you tag images with names like `dev`, `staging`, and `prod` | `set(string)` | `[]` | no | diff --git a/docs/terraform.md b/docs/terraform.md index 98a949d..0fb8073 100644 --- a/docs/terraform.md +++ b/docs/terraform.md @@ -68,7 +68,7 @@ | [prefixes\_pull\_through\_repositories](#input\_prefixes\_pull\_through\_repositories) | Organization IDs to provide with push access to the ECR | `list(string)` | `[]` | no | | [principals\_full\_access](#input\_principals\_full\_access) | Principal ARNs to provide with full access to the ECR | `list(string)` | `[]` | no | | [principals\_lambda](#input\_principals\_lambda) | Principal account IDs of Lambdas allowed to consume ECR | `list(string)` | `[]` | no | -| [principals\_pull\_though\_access](#input\_principals\_pull\_though\_access) | Principal ARNs to provide with pull though access to the ECR | `list(string)` | `[]` | no | +| [principals\_pull\_through\_access](#input\_principals\_pull\_through\_access) | Principal ARNs to provide with pull through access to the ECR | `list(string)` | `[]` | no | | [principals\_push\_access](#input\_principals\_push\_access) | Principal ARNs to provide with push access to the ECR | `list(string)` | `[]` | no | | [principals\_readonly\_access](#input\_principals\_readonly\_access) | Principal ARNs to provide with readonly access to the ECR | `list(string)` | `[]` | no | | [protected\_tags](#input\_protected\_tags) | Name of image tags prefixes that should not be destroyed. Useful if you tag images with names like `dev`, `staging`, and `prod` | `set(string)` | `[]` | no | diff --git a/main.tf b/main.tf index 8728f3a..674993b 100644 --- a/main.tf +++ b/main.tf @@ -1,6 +1,6 @@ locals { principals_readonly_access_non_empty = length(var.principals_readonly_access) > 0 - principals_pull_through_access_non_empty = length(var.principals_pull_though_access) > 0 + principals_pull_through_access_non_empty = length(var.principals_pull_through_access) > 0 principals_push_access_non_empty = length(var.principals_push_access) > 0 principals_full_access_non_empty = length(var.principals_full_access) > 0 principals_lambda_non_empty = length(var.principals_lambda) > 0 @@ -11,7 +11,7 @@ locals { ecr_need_policy = ( length(var.principals_full_access) + length(var.principals_readonly_access) - + length(var.principals_pull_though_access) + + length(var.principals_pull_through_access) + length(var.principals_push_access) + length(var.principals_lambda) + length(var.organizations_readonly_access) @@ -147,7 +147,7 @@ data "aws_iam_policy_document" "resource_pull_through_cache" { principals { type = "AWS" - identifiers = var.principals_pull_though_access + identifiers = var.principals_pull_through_access } actions = [ diff --git a/variables.tf b/variables.tf index 4917bfa..9c7ce84 100644 --- a/variables.tf +++ b/variables.tf @@ -22,9 +22,9 @@ variable "principals_readonly_access" { default = [] } -variable "principals_pull_though_access" { +variable "principals_pull_through_access" { type = list(string) - description = "Principal ARNs to provide with pull though access to the ECR" + description = "Principal ARNs to provide with pull through access to the ECR" default = [] }