Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: AttributeEditor gridLayout is required for more than 6 attributes. Cannot render. #3296

Open
2 tasks done
Yuhao-C opened this issue Feb 14, 2025 · 1 comment
Open
2 tasks done
Labels
bug Something isn't working response-requested

Comments

@Yuhao-C
Copy link

Yuhao-C commented Feb 14, 2025

Browser

Chrome, Safari, Firefox, Edge

Package version

v3.0.900

React version

^18.2.60

Description

After #3212, AttributeEditor does not render if definition.length > 6. Isn't it a breaking change? Why only patch version is increased? Please fix.

Source code

No response

Reproduction

No response

Code of Conduct

@Yuhao-C Yuhao-C added the bug Something isn't working label Feb 14, 2025
@just-boris
Copy link
Member

Hello!

Before that change, the attribute editor supported 4 columns at most. If you tried to put more columns than that, that behavior was unspecified.

So, this is not a breaking change. We just made the former existing contract more clearly enforced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working response-requested
Projects
None yet
Development

No branches or pull requests

2 participants