Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Allow for more ways to specify density #22

Open
jennyfothergill opened this issue Nov 11, 2020 · 2 comments
Open

Allow for more ways to specify density #22

jennyfothergill opened this issue Nov 11, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@jennyfothergill
Copy link
Member

Being able to specify density in terms of volume fractions or number density are also important considerations if someone is using a coarse or toy model that doesn't have physical unit connections (yet).

@mikemhenry
Copy link
Member

To support this will will have to see if unyt either has a dimensionless unit or if we will just have to make a custom unit to handle something like volume fraction or number density.

@jennyfothergill
Copy link
Member Author

note for later:
unyt does have a dimensionless quantity

import unyt as u

mass = 1 * u.kg
volume = 10 * u.m **3
density = mass/volume

number = 2 * u.dimensionless
number_density = number / volume

results in
0.1 kg/m**3
0.2 dimensionless/m**3

I think we can add some logic to detect different density inputs, (number density, density, maybe even occupied volume?)

@jennyfothergill jennyfothergill added the good first issue Good for newcomers label Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants