Skip to content

Commit ffa4aef

Browse files
committed
Commit Status is not necessary?
1 parent b35d107 commit ffa4aef

2 files changed

Lines changed: 4 additions & 40 deletions

File tree

process_pr.py

Lines changed: 4 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -2119,28 +2119,6 @@ def process_pr(
21192119
last_commit_obj.create_status(
21202120
"success", description=desc, target_url=turl, context=bot_status_name
21212121
)
2122-
build_only_status = get_status(
2123-
cms_status_prefix + "/build-only", commit_statuses
2124-
)
2125-
if build_only:
2126-
if (not build_only_status) or (
2127-
build_only_status.description != "Only build"
2128-
):
2129-
last_commit_obj.create_status(
2130-
"success",
2131-
description="Only build",
2132-
target_url=turl,
2133-
context=cms_status_prefix + "/build-only",
2134-
)
2135-
else:
2136-
if build_only_status and build_only_status.description != "Build and test":
2137-
last_commit_obj.create_status(
2138-
"success",
2139-
description="Build and test",
2140-
target_url=turl,
2141-
context=cms_status_prefix + "/build-only",
2142-
)
2143-
21442122
set_comment_emoji_cache(dryRun, bot_cache, test_comment, repository)
21452123

21462124
if bot_status:
@@ -2255,14 +2233,10 @@ def process_pr(
22552233
lab_state = "required"
22562234
if lab_state not in lab_stats:
22572235
lab_state = "optional"
2258-
build_only_status = get_status(cms_status_prefix + "/build-only", commit_statuses)
2259-
if not (build_only_status and build_only_status.description == "Only build"):
2260-
if (lab_state in lab_stats) and ("pending" not in lab_stats[lab_state]):
2261-
signatures["tests"] = "approved"
2262-
if "error" in lab_stats[lab_state]:
2263-
signatures["tests"] = "rejected"
2264-
else:
2265-
signatures["tests"] = "pending"
2236+
if (lab_state in lab_stats) and ("pending" not in lab_stats[lab_state]):
2237+
signatures["tests"] = "approved"
2238+
if "error" in lab_stats[lab_state]:
2239+
signatures["tests"] = "rejected"
22662240
elif not bot_status:
22672241
if not dryRun:
22682242
last_commit_obj.create_status(

tests/PRActionData/TestProcessPr.test_build_only.json

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,6 @@
2626
"context": "bot/40/jenkins"
2727
}
2828
},
29-
{
30-
"type": "status",
31-
"data": {
32-
"commit": "06336c8884bcfbc516cc69fd99b0a161bb3a14d5",
33-
"state": "success",
34-
"target_url": "https://github.com/iarspider-cmssw/cmssw/pull/40#issuecomment-2872583904",
35-
"description": "Only build",
36-
"context": "cms/40/build-only"
37-
}
38-
},
3929
{
4030
"type": "emoji",
4131
"data": [

0 commit comments

Comments
 (0)