automatically assign "type"

[vlimant]

In the discussion with PF @ahinzmann @stahlleiton , we were wondering if type could be set automatically, the same way categories are, instead of people having to set it manually

[cmsbuild]

cms-bot internal usage

[cmsbuild]

A new Issue was created by @vlimant.

@Dr15Jones, @ftenchini, @makortel, @mandrenguyen, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[makortel]

assign core

[cmsbuild]

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

[makortel]

There is already a functionality to set labels (that are distinct from the type labels) according to packages

cms-bot/categories_map.py

Lines 1840 to 1932 in 8ef6d43

	# Just like CMSSW_CATEGORIES but it creates non-blocking (no signature needed) github labels
	# This can be used to automatically create non-blocking labels for selected packages instead of
	# explicit `type label`. Only valid dpg/pog groups can be added as labels
	# Format: label = [regexp1, regexp2]
	# where regexpX can be part of cmssw package e.g SiStrip will match all cmssw packages with SiStrip in them
	# "jetmet": [ "SubSystem1/", "SubSystem2/Package"]
	import re
	CMSSW_LABELS = {
	"changes-dataformats": [re.compile("^.+/src/classes_def(.+|).xml$")],
	"trk": [
	"Alignment/APEEstimation",
	"Alignment/HIPAlignmentAlgorithm",
	"Alignment/KalmanAlignmentAlgorithm",
	"Alignment/Laser",
	"Alignment/MillePedeAlignmentAlgorithm",
	"Alignment/OfflineValidation",
	"Alignment/ReferenceTrajectories",
	"Alignment/SurveyAnalysis",
	"Alignment/TrackerAlignment",
	"Alignment/TwoBodyDecay",
	"AnalysisAlgos/SiStripClusterInfoProducer",
	"CalibFormats/SiPixel",
	"CalibFormats/SiStrip",
	"CalibTracker/",
	"Calibration/TkAlCaRecoProducers",
	"CommonTools/TrackerMap",
	"CondCore/SiPhase2",
	"CondCore/SiPixel",
	"CondCore/SiStrip",
	"CondFormats/SiPhase2",
	"CondFormats/SiPixel",
	"CondFormats/SiStrip" "CondTools/SiPhase2",
	"CondTools/SiPixel",
	"CondTools/SiStrip",
	"CUDADataFormats/SiPixel",
	"CUDADataFormats/SiStrip",
	"DPGAnalysis/SiStripTools",
	"DataFormats/Phase2ITPixelCluster",
	"DataFormats/Phase2Tracker",
	"DataFormats/PixelMatchTrackReco",
	"DataFormats/SiPixel",
	"DataFormats/SiStrip",
	"DQM/SiOuterTracker",
	"DQM/SiPixel",
	"DQM/SiStrip",
	"DQM/SiTracker",
	"DQM/Tracker",
	"DQMOffline/CalibTracker",
	"EventFilter/Phase2TrackerRawToDigi",
	"EventFilter/SiPixelRawToDigi",
	"EventFilter/SiStripRawToDigi",
	"FastSimulation/TrackerSetup",
	"Geometry/Tracker",
	"L1Trigger/Tracker",
	"OnlineDB/SiStrip",
	"RecoLocalTracker/",
	"SimTracker/",
	"Validation/Si",
	"Validation/Tracker",
	],
	"tracking": [
	"AnalysisAlgos/TrackInfoProducer",
	"AnalysisDataFormats/TrackInfo",
	"CondCore/BeamSpot",
	"CondFormats/BeamSpot",
	"CondTools/BeamSpot",
	"CUDADataFormats/Track",
	"CUDADataFormats/Vertex",
	"DataFormats/BeamSpot",
	"DataFormats/Track",
	"DataFormats/VertexReco",
	"DataFormats/V0Candidate",
	"DataFormats/VZero",
	"DQM/BeamMonitor",
	"DQMOffline/RecoB",
	"DQM/Tracking",
	"FastSimulation/Tracking",
	"Geometry/GlobalTracking",
	"RecoHI/HiTracking",
	"RecoPixelVertexing/",
	"RecoTracker/",
	"RecoVertex/",
	"SimGeneral/TrackingAnalysis",
	"TrackPropagation/",
	"TrackingTools/",
	"Validation/RecoPixelVertexing",
	"Validation/RecoTrack",
	"Validation/RecoVertex",
	"Validation/Tracking",
	],
	"hcal": ["DPGAnalysis/HcalNanoAOD"],
	}

[makortel]

What type label in particular would you like to be set automatically, and based on what criteria?

[vlimant]

excellent, thanks for the pointer !
then it's up to @ahinzmann and @stahlleiton to make a PR to this mapping with the directory they would like to watch under type=pf

[makortel]

Do I understand correctly that there is no pf type label at the moment? AFAICT those are specified in

cms-bot/githublabels.py

Lines 32 to 46 in 8ef6d43

	TYPE_COMMANDS = {
	"bug-fix": [LABEL_COLORS["bug"], "bug(?:-?fix)?", "type"],
	"new-feature": [LABEL_COLORS["info"], "(?:new-)?(?:feature|idea)", "type"],
	"root": [LABEL_COLORS["info"], "root", "mtype"],
	"documentation": [LABEL_COLORS["doc"], "doc(?:umentation)?", "mtype"],
	"hlt-integration": [LABEL_COLORS["doc"], "hlt-int(?:egration)?", "mtype"],
	"changes-dataformats": [LABEL_COLORS["doc"], "(?:changes?-)?dataformats?", "mtype"],
	"performance-improvements": [
	LABEL_COLORS["performance"],
	"performance|improvements|performance-improvements",
	"mtype",
	],
	"evolution": [LABEL_COLORS["info"], "evo(?:lution)?", "mtype"],
	"ngt": [LABEL_COLORS["performance"], "ngt", "mtype"],
	}

and I don't see pf there.