From 992d2ed6d7c2b59f13e69692b5b1361ea980cfbf Mon Sep 17 00:00:00 2001
From: iarspider <iarspider@gmail.com>
Date: Wed, 29 Jan 2025 09:37:06 +0100
Subject: [PATCH 1/3] Remove unused variable in TestAssociator.cc

---
 SimTracker/TrackerHitAssociation/test/TestAssociator.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/SimTracker/TrackerHitAssociation/test/TestAssociator.cc b/SimTracker/TrackerHitAssociation/test/TestAssociator.cc
index 2d38af8a85fd1..0d44646564908 100644
--- a/SimTracker/TrackerHitAssociation/test/TestAssociator.cc
+++ b/SimTracker/TrackerHitAssociation/test/TestAssociator.cc
@@ -109,7 +109,7 @@ void TestAssociator::printRechitSimhit(const edm::Handle<edmNew::DetSetVector<re
           edm::LogVerbatim("TrackAssociator")
               << " simtrack ID = " << m.trackId() << "                            Simhit Pos = " << m.localPosition();
           // Seek the smallest residual
-          if (const SiPixelRecHit* dummy = dynamic_cast<const SiPixelRecHit*>(&rechit)) {
+          if (dynamic_cast<const SiPixelRecHit*>(&rechit)) {
             isPixel = true;
             dist = (rechit.localPosition() - m.localPosition()).mag();  // pixels measure 2 dimensions
           } else {

From 27dff1aec781e44e61822b963cda2f3146850893 Mon Sep 17 00:00:00 2001
From: iarspider <iarspider@gmail.com>
Date: Fri, 31 Jan 2025 10:43:10 +0100
Subject: [PATCH 2/3] Update TestAssociator.cc

---
 SimTracker/TrackerHitAssociation/test/TestAssociator.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/SimTracker/TrackerHitAssociation/test/TestAssociator.cc b/SimTracker/TrackerHitAssociation/test/TestAssociator.cc
index 0d44646564908..c87119fa020a7 100644
--- a/SimTracker/TrackerHitAssociation/test/TestAssociator.cc
+++ b/SimTracker/TrackerHitAssociation/test/TestAssociator.cc
@@ -109,7 +109,8 @@ void TestAssociator::printRechitSimhit(const edm::Handle<edmNew::DetSetVector<re
           edm::LogVerbatim("TrackAssociator")
               << " simtrack ID = " << m.trackId() << "                            Simhit Pos = " << m.localPosition();
           // Seek the smallest residual
-          if (dynamic_cast<const SiPixelRecHit*>(&rechit)) {
+          auto ptr = dynamic_cast<const SiPixelRecHit*>(&rechit));
+          if (nullptr != ptr) {
             isPixel = true;
             dist = (rechit.localPosition() - m.localPosition()).mag();  // pixels measure 2 dimensions
           } else {

From f9945249fdc55c45c2545c3c44cd4ae0d5ba4854 Mon Sep 17 00:00:00 2001
From: iarspider <iarspider@gmail.com>
Date: Fri, 31 Jan 2025 11:15:55 +0100
Subject: [PATCH 3/3] Update TestAssociator.cc

---
 SimTracker/TrackerHitAssociation/test/TestAssociator.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/SimTracker/TrackerHitAssociation/test/TestAssociator.cc b/SimTracker/TrackerHitAssociation/test/TestAssociator.cc
index c87119fa020a7..3fd83fb8da39b 100644
--- a/SimTracker/TrackerHitAssociation/test/TestAssociator.cc
+++ b/SimTracker/TrackerHitAssociation/test/TestAssociator.cc
@@ -109,7 +109,7 @@ void TestAssociator::printRechitSimhit(const edm::Handle<edmNew::DetSetVector<re
           edm::LogVerbatim("TrackAssociator")
               << " simtrack ID = " << m.trackId() << "                            Simhit Pos = " << m.localPosition();
           // Seek the smallest residual
-          auto ptr = dynamic_cast<const SiPixelRecHit*>(&rechit));
+          auto ptr = dynamic_cast<const SiPixelRecHit*>(&rechit);
           if (nullptr != ptr) {
             isPixel = true;
             dist = (rechit.localPosition() - m.localPosition()).mag();  // pixels measure 2 dimensions