diff --git a/test/storage/b_plus_tree_delete_test.cpp b/test/storage/b_plus_tree_delete_test.cpp index 80bd118e9..b7e9d414c 100644 --- a/test/storage/b_plus_tree_delete_test.cpp +++ b/test/storage/b_plus_tree_delete_test.cpp @@ -24,7 +24,7 @@ namespace bustub { using bustub::DiskManagerUnlimitedMemory; -TEST(BPlusTreeTests, DISABLED_DeleteTest) { +TEST(BPlusTreeTests, DISABLED_DeleteTestNoIterator) { // create KeyComparator and index schema auto key_schema = ParseCreateStatement("a bigint"); GenericComparator<8> comparator(key_schema.get()); diff --git a/test/storage/b_plus_tree_insert_test.cpp b/test/storage/b_plus_tree_insert_test.cpp index 1c7fb817d..f1a67c7a0 100644 --- a/test/storage/b_plus_tree_insert_test.cpp +++ b/test/storage/b_plus_tree_insert_test.cpp @@ -23,7 +23,7 @@ namespace bustub { using bustub::DiskManagerUnlimitedMemory; -TEST(BPlusTreeTests, DISABLED_InsertTest1) { +TEST(BPlusTreeTests, DISABLED_BasicInsertTest) { // create KeyComparator and index schema auto key_schema = ParseCreateStatement("a bigint"); GenericComparator<8> comparator(key_schema.get()); @@ -56,7 +56,7 @@ TEST(BPlusTreeTests, DISABLED_InsertTest1) { delete bpm; } -TEST(BPlusTreeTests, DISABLED_InsertTest2) { +TEST(BPlusTreeTests, DISABLED_InsertTest1NoIterator) { // create KeyComparator and index schema auto key_schema = ParseCreateStatement("a bigint"); GenericComparator<8> comparator(key_schema.get()); @@ -95,7 +95,7 @@ TEST(BPlusTreeTests, DISABLED_InsertTest2) { delete bpm; } -TEST(BPlusTreeTests, DISABLED_InsertTest3) { +TEST(BPlusTreeTests, DISABLED_InsertTest2) { // create KeyComparator and index schema auto key_schema = ParseCreateStatement("a bigint"); GenericComparator<8> comparator(key_schema.get()); @@ -105,7 +105,7 @@ TEST(BPlusTreeTests, DISABLED_InsertTest3) { // allocate header_page page_id_t page_id = bpm->NewPage(); // create b+ tree - BPlusTree, RID, GenericComparator<8>> tree("foo_pk", page_id, bpm, comparator); + BPlusTree, RID, GenericComparator<8>> tree("foo_pk", page_id, bpm, comparator, 2, 3); GenericKey<8> index_key; RID rid; @@ -130,12 +130,12 @@ TEST(BPlusTreeTests, DISABLED_InsertTest3) { int64_t start_key = 1; int64_t current_key = start_key; - index_key.SetFromInteger(start_key); - for (auto iterator = tree.Begin(index_key); iterator != tree.End(); ++iterator) { - auto location = (*iterator).second; + for (auto iter = tree.Begin(); iter != tree.End(); ++iter) { + auto pair = *iter; + auto location = pair.second; EXPECT_EQ(location.GetPageId(), 0); EXPECT_EQ(location.GetSlotNum(), current_key); - ++current_key; + current_key = current_key + 1; } EXPECT_EQ(current_key, keys.size() + 1); @@ -143,11 +143,11 @@ TEST(BPlusTreeTests, DISABLED_InsertTest3) { start_key = 3; current_key = start_key; index_key.SetFromInteger(start_key); - for (auto iterator = tree.Begin(index_key); iterator != tree.End(); ++iterator) { + for (auto iterator = tree.Begin(index_key); !iterator.IsEnd(); ++iterator) { auto location = (*iterator).second; EXPECT_EQ(location.GetPageId(), 0); EXPECT_EQ(location.GetSlotNum(), current_key); - ++current_key; + current_key = current_key + 1; } delete bpm; } diff --git a/test/storage/b_plus_tree_sequential_scale_test.cpp b/test/storage/b_plus_tree_sequential_scale_test.cpp index b0069e5ea..000103e3b 100644 --- a/test/storage/b_plus_tree_sequential_scale_test.cpp +++ b/test/storage/b_plus_tree_sequential_scale_test.cpp @@ -27,7 +27,7 @@ using bustub::DiskManagerUnlimitedMemory; /** * (Fall 2024) You should pass this test after finishing insertion and point search. */ -TEST(BPlusTreeTests, DISABLED_ScaleTest) { // NOLINT +TEST(BPlusTreeTests, DISABLED_BasicScaleTest) { // NOLINT // create KeyComparator and index schema auto key_schema = ParseCreateStatement("a bigint"); GenericComparator<8> comparator(key_schema.get());