mollify sonarcloud

Author: dsweber2

src/server/admin/api_key_form_script.js

@@ -14,7 +14,7 @@ function onSubmit(e) {
     var allResponses = form.getResponses();
     var latestResponse = allResponses[allResponses.length - 1];
 
-    var user_api_key = Math.random().toString(16).substr(2, 18);
+    var user_api_key = Utilities.getUuid().replace(/-/g, '');
     var user_email = latestResponse.getRespondentEmail();
 
     var payload = {
@@ -53,7 +53,7 @@ function onSubmit(e) {
         });
     } else if (result.getResponseCode() == 409) {
         Logger.log('Email already registered, replacing key for %s', user_email);
-        var new_api_key = Math.random().toString(16).substr(2, 18);
+        var new_api_key = Utilities.getUuid().replace(/-/g, '');
         var replacePayload = {
             'token': WEBHOOK_SECRET,
             'user_api_key': new_api_key,
@@ -108,7 +108,7 @@ function backfillRegistrationsSince(cutoffDate, dryRun) {
             continue;
         }
 
-        var user_api_key = Math.random().toString(16).substr(2, 18);
+        var user_api_key = Utilities.getUuid().replace(/-/g, '');
 
         if (dryRun) {
             Logger.log('DRY RUN — would register: %s with key: %s', user_email, user_api_key);

src/server/endpoints/admin.py

@@ -123,7 +123,7 @@ def _register():
                 409,
             )
         User.create_user(api_key=user_api_key, email=user_email, session=session)
-    return make_response(f"Successfully registered API key '{user_api_key}'", 200)
+    return make_response(f"Successfully registered API key for {user_email}", 200, {"Content-Type": "text/plain"})
 
 
 @bp.route("/replace_key", methods=["POST"])
@@ -141,7 +141,7 @@ def _replace_key():
             return make_response("No user found with that email address", 404)
         existing_roles = {role.name for role in user.roles}
         User.update_user(user=user, api_key=user_api_key, email=user_email, roles=existing_roles, session=session)
-    return make_response(f"Successfully replaced API key for '{user_email}'", 200)
+    return make_response(f"Successfully replaced API key for {user_email}", 200, {"Content-Type": "text/plain"})
 
 
 @bp.route("/diagnostics", methods=["GET", "PUT", "POST", "DELETE"])