Skip to content

Jmr/v5 docs - #1747

Merged
JavierMtzRdz merged 36 commits into
devfrom
jmr/v5-docs
Jul 8, 2026
Merged

Jmr/v5 docs#1747
JavierMtzRdz merged 36 commits into
devfrom
jmr/v5-docs

Conversation

@JavierMtzRdz

@JavierMtzRdz JavierMtzRdz commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

addresses issue(s) #ISSUE

Summary:

Adds and updates documentation for the Delphi V5 API, covering two new data sources and improvements to the V5 reference pages.

  • Added an initial V5 subpage with an overview of the API and its structure.
  • Added a link to the V5 API from the main documentation index.
  • Rearranged the subpages to place the V5 subpage second.
  • Created the v5-signals/ folder and the "Sources and Signals" subpage.
  • Added a formatted NWSS signal page based on @dsweber2 's documentation.
  • Added a new V5 signal page documenting the Epic Cosmos source based on @aysim319 's documentation.
  • Added references from the signal index and main V5 page.

TODO:

  • Add "Manually Constructing V5 Queries" subpage
  • Include a subpage for time and geo type.
  • Finish the documentation subpages for the other available sources.
    • NHSN
    • NSSP
    • Claims
    • Meta

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

dsweber2
dsweber2 previously approved these changes Jun 8, 2026

@dsweber2 dsweber2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also hacked together something that would let us live-fill the temporal scope start/latest data available into the docs using the metadata endpoint, but I'll put that in a PR on this

Comment thread docs/api/v5.md Outdated
Comment thread docs/api/v5.md Outdated
Comment thread docs/api/v5-signals/nwss.md Outdated
Comment thread docs/api/v5-signals/nwss.md
Comment thread docs/api/v5.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this maybe centers the old API a little bit to much for a longterm version of this, but for now this works fine

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the second paragraph if preferred. I just wanted to give a little context.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth talking about, I'm not sure having it be the ~first thing you see in the docs is right. Seems like something for a migration section (which we may also want w/a description of the key differences (all dates vs ideosyncratic ints, different endpoint structure, a couple of translation of typical calls).

I don't think it's make or break but at some point we should probably make it like that.

@JavierMtzRdz JavierMtzRdz Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I've moved it to a section below to allow for a more detailed discussion of the migration later

Comment thread docs/api/v5-signals/nwss.md Outdated
Comment thread docs/api/v5-signals/nwss.md
Comment thread docs/api/v5-signals/epic-cosmos.md
Comment thread docs/api/v5-signals/epic-cosmos.md
Comment thread docs/api/v5-signals/epic-cosmos.md Outdated
Co-authored-by: David Weber <david.weber2@pm.me>
Co-authored-by: Javier {∅, Rdz} <39629918+JavierMtzRdz@users.noreply.github.com>
@JavierMtzRdz
JavierMtzRdz requested a review from dsweber2 June 8, 2026 22:55

@JavierMtzRdz JavierMtzRdz left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have addressed previous comments.

Comment thread docs/api/v5-signals/epic-cosmos.md
Comment thread docs/api/v5-signals/epic-cosmos.md
Comment thread docs/api/v5-signals/nwss.md
Comment thread docs/api/v5-signals/nwss.md Outdated
Comment thread docs/api/v5.md

@JavierMtzRdz JavierMtzRdz Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I've moved it to a section below to allow for a more detailed discussion of the migration later

Comment thread docs/api/v5-signals/epic-cosmos.md Outdated
| **Data Source** | [Epic Cosmos](https://cosmos.epic.com/) via [PopHIVE](https://github.com/PopHIVE/Ingest) |
| **Geographic Levels** | HHS Regions (`hhs`), nation, state |
| **Temporal Granularity** | Weekly (epiweeks; dates are Saturdays, the last day of the week) |
| **Reporting Cadence** | Weekly |

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporting cadence is spotty at best. I think it's supposed to be biweekly, but we often get a whole month of lag. Not sure how to put that all into nice documentation words though

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

biweekly-monthly maybe? not ideal, probably best to elaborate in text

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I selected Irregular and included a note because it varies significantly.

library(epidatr)
library(dplyr)

archive_df <- epidata_archive(
  source = "pophive",
  signal = "covid_pct_ed",
  geo_type = "state"
)

archive_df %>%
  distinct(report_time) %>%
  arrange(report_time) %>%
  mutate(days_since_last = as.numeric(difftime(report_time, lag(report_time), units = "days"))) %>%
 count(days_since_last)
# A tibble: 13 × 2
   days_since_last     n
             <dbl> <int>
 1               1     2
 2               7     1
 3               8     1
 4              13     1
 5              14     3
 6              15     2
 7              16     2
 8              17     1
 9              19     1
10              20     1
11              27     1
12              37     1
13              NA     1

@sonarqubecloud

Copy link
Copy Markdown

@JavierMtzRdz
JavierMtzRdz merged commit cd7981d into dev Jul 8, 2026
10 of 11 checks passed
@JavierMtzRdz
JavierMtzRdz deleted the jmr/v5-docs branch July 8, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants