Skip to content

Incorporate syntax updates #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
9 tasks done
alicecima opened this issue Aug 13, 2024 · 2 comments · Fixed by #17
Closed
9 tasks done

Incorporate syntax updates #16

alicecima opened this issue Aug 13, 2024 · 2 comments · Fixed by #17

Comments

@alicecima
Copy link

alicecima commented Aug 13, 2024

The name/structure of some functions in the epi libraries seem to have changed, so parts of the tooling book's code do not currently work.

In general:

  • Change covidcast() to pub_covidcast(), and adjust arguments.
  • Change pivot_quantiles to pivot_quantiles_wider.
  • Change levels to quantile_levels in arx_args_list.
  • Change probs to quantile_levels in layer_residual_quantiles, and flatline_args_list.
  • Change tau to quantile_levels in quantile_reg.

Chapter 2:

  • At line get
    #Warning messages:
    1: epi_archive constructor argument geo_type is now ignored. Consider removing.
    2: epi_archive constructor argument time_type is now ignored. Consider removing.

Chapter 6:

  • Error because NULL is not accepted anymore for seasonal_period
  • Error with unnest(outlier_info)

Chapter 7:

  • Error because archive_cases_dv_subset_dt does not exist
@dshemetov
Copy link
Contributor

dshemetov commented Aug 20, 2024

Thanks for this comprehensive list Alice! I know that some of these changes have been addressed in #12 (it's been a while, but I recall addressing covidcast() -> pub_covidcast() at least), but we just haven't gotten around to merging that in. We should probably merge that PR in and open a new one for the rest of your checklist (I don't think #12 needs to be re-reviewed). @brookslogan for visibility.

@dshemetov dshemetov linked a pull request Oct 2, 2024 that will close this issue
@dshemetov
Copy link
Contributor

closed by #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants