Skip to content

Change n -> before, after in detect_outlr_rm #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brookslogan opened this issue Aug 18, 2022 · 2 comments
Closed

Change n -> before, after in detect_outlr_rm #214

brookslogan opened this issue Aug 18, 2022 · 2 comments
Labels
enhancement New feature or request op-semantics Operational semantics; many potentially breaking changes here P2 low priority

Comments

@brookslogan
Copy link
Contributor

Split out from discussion on #188.
@brookslogan brookslogan added enhancement New feature or request P2 low priority labels Aug 18, 2022
@kenmawer
Copy link
Contributor

Just so you know, rm confused me at first, as I thought it meant "remove" rather than "rolling median."

@brookslogan brookslogan added the op-semantics Operational semantics; many potentially breaking changes here label Sep 20, 2022
@brookslogan
Copy link
Contributor Author

We've moved back to .n + .align in epi_slide*, so this doesn't make sense (unless maybe we wanted to add a .align arg here). Refiling naming comment in another issue.

@brookslogan brookslogan closed this as not planned Won't fix, can't repro, duplicate, stale Oct 15, 2024
@brookslogan brookslogan mentioned this issue Oct 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request op-semantics Operational semantics; many potentially breaking changes here P2 low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brookslogan @kenmawer