Skip to content

Refactor epi[x]_slide to reduce code duplication #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookslogan opened this issue Nov 11, 2022 · 1 comment
Closed

Refactor epi[x]_slide to reduce code duplication #244

brookslogan opened this issue Nov 11, 2022 · 1 comment
Labels
cleanup improvements to developing&building experience&quality, not directly to built pkg&docs P3 very low priority

Comments

@brookslogan
Copy link
Contributor

brookslogan commented Nov 11, 2022

E.g.,

  • Create utilities to process f, ..., & any other appropriate args into uniform types (e.g., process function&args/formula&args/missing&tidyeval into a uniform function f and ... args), apply in both epi_slide and epix_slide, and simplify away related branching so that group_modify & {slide,comp}_one_grp are referenced only once per slide function.
  • Consider making some element/row-recycling utilities, although note differences in how this work in epi_slide vs. epix_slide (discussion in group_by() for epi_archive objects #64 and docs in associated feature branch may be helpful).
  • Related: Allow multiple column computations in data masking slides #235.
@brookslogan brookslogan added P3 very low priority cleanup improvements to developing&building experience&quality, not directly to built pkg&docs labels Nov 11, 2022
@brookslogan
Copy link
Contributor Author

A lot of this has been accomplished in handling #326, and other parts like row-recycling probably don't apply anymore, as we don't do that for epi_slide_opt, epix_slide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup improvements to developing&building experience&quality, not directly to built pkg&docs P3 very low priority
Projects
None yet
Development

No branches or pull requests

1 participant