Skip to content

Consider allowing negative after values #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookslogan opened this issue Mar 27, 2023 · 2 comments
Closed

Consider allowing negative after values #287

brookslogan opened this issue Mar 27, 2023 · 2 comments
Labels
enhancement New feature or request P2 low priority

Comments

@brookslogan
Copy link
Contributor

In advanced.Rmd, we fit a nowcasting model for y given x using epi_slide. However, beyond the latency&revision-naiveness, it is also will give unrealistic performance because it includes the testing data in the training data. If we want to enable this type of operation (questionable; should we route solely to epi_archive?), it'd be nice to be able to set after = -k when the reporting latency is expected to be k.

@brookslogan brookslogan added enhancement New feature or request P2 low priority documentation Improvements or additions to documentation labels Mar 27, 2023
@brookslogan brookslogan removed the documentation Improvements or additions to documentation label Mar 27, 2023
@brookslogan
Copy link
Contributor Author

brookslogan commented Mar 27, 2023

See discussion in #288 for why after = -1 would not be appropriate here unless we separated the fit (slide with before = 2, ahead - 1) and predict (mutate/etc.) steps.

Perhaps a more important use case, motivating the addition of an after parameter and allowing it to be negative would be for epix_slide extracting a particular lag (though doing this for each lag doesn't sound great for efficiency; maybe this needs to be its own function even though technically we could do it with an epix_slide).

@dshemetov
Copy link
Contributor

Closing as out of date. We no longer have the after argument.

@dshemetov dshemetov closed this as not planned Won't fix, can't repro, duplicate, stale Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 low priority
Projects
None yet
Development

No branches or pull requests

2 participants