Skip to content

unnest.epi_df doesn't update other_keys #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brookslogan opened this issue Apr 27, 2023 · 2 comments
Open

unnest.epi_df doesn't update other_keys #306

brookslogan opened this issue Apr 27, 2023 · 2 comments
Labels
bug Something isn't working P2 low priority

Comments

@brookslogan
Copy link
Contributor

Case A: we're unnesting a list col that was a key: not sure if this is even something we'd run into

Case B: we're unnesting a list col that wasn't a key. We're probably expanding the row set. To get a unique key, some of the columns from unnesting should be included in other_keys. We need help in identifying these, either from a special class or directly from user.

Case C: we're unnesting a tibble-type / vctrs generalization but not list column that was a key: probably we should replace the original column with all new columns as keys, but this isn't 100% guaranteed. We might need some help from the unnested object to point to what new columns should be considered keys.

Case D: like Case C but for a non-key. Assuming this can't expand the rowset, then we don't need any other_keys updates.

@brookslogan brookslogan added bug Something isn't working P2 low priority labels Apr 27, 2023
@brookslogan
Copy link
Contributor Author

Could consider this part of #223.

@brookslogan
Copy link
Contributor Author

Also an issue with joins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 low priority
Projects
None yet
Development

No branches or pull requests

1 participant