Skip to content

Fix epi_df creators #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajmcdon opened this issue May 4, 2023 · 1 comment
Open

Fix epi_df creators #312

dajmcdon opened this issue May 4, 2023 · 1 comment
Labels
cleanup improvements to developing&building experience&quality, not directly to built pkg&docs good first issue Good for newcomers

Comments

@dajmcdon
Copy link
Contributor

dajmcdon commented May 4, 2023

#' @export

  • as_epi_df() does the validation and wraps new_epi_df(), so that's all the user would need.
  • new_epi_df() should not be exported unless it validates it's arguments.
  • as_epi_df() needs to validate that any column names in additional_metadata$other_keys are in x.

(We may also want to consider making other_keys a specific argument rather than forcing it to be part of the additional_metadata list.)

@dajmcdon dajmcdon added good first issue Good for newcomers cleanup improvements to developing&building experience&quality, not directly to built pkg&docs labels May 4, 2023
@brookslogan
Copy link
Contributor

brookslogan commented May 5, 2023

Think this is basically[Related:] #301 + #186 but probably good to have it near the top of the issue list. [Also related: #166]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup improvements to developing&building experience&quality, not directly to built pkg&docs good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants