Skip to content

Commit cc826f0

Browse files
committed
fix _prepare_field() and order_by() methods
1 parent 4689ac9 commit cc826f0

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

simple_query_builder/querybuilder.py

+7-4
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ def _prepare_field(self, field: str = '') -> str:
355355
self.set_error(f"Empty field in {inspect.stack()[0][3]} method")
356356
return ''
357357

358-
if field.find('(') > -1 or field.find(')') > -1:
358+
if field.find('(') > -1 or field.find(')') > -1 or field.find('*') > -1:
359359
if field.find(' AS ') > -1:
360360
field = field.replace(' AS ', ' AS `')
361361
return f"{field}`"
@@ -364,7 +364,7 @@ def _prepare_field(self, field: str = '') -> str:
364364
else:
365365
field = field.replace('.', '`.`')
366366
field = field.replace(' AS ', '` AS `')
367-
return field if field == '*' else f"`{field}`"
367+
return f"`{field}`"
368368

369369
def _prepare_fieldlist(self, fields: Union[str, tuple, list] = ()) -> str:
370370
result = ''
@@ -393,8 +393,11 @@ def order_by(self, field: Union[str, tuple, list] = (), sort: str = ''):
393393
else:
394394
self._sql += f" ORDER BY {field}"
395395
elif isinstance(field, tuple) or isinstance(field, list):
396-
new_list = [f"{self._prepare_sorting(item)[0]} {self._prepare_sorting(item)[1]}" for item in field]
397-
self._sql += ' ORDER BY ' + self._prepare_fieldlist(new_list)
396+
new_list = []
397+
for item in field:
398+
new_item = self._prepare_sorting(item)
399+
new_list.append(f"{new_item[0]} {new_item[1]}")
400+
self._sql += ' ORDER BY ' + ', '.join(new_list)
398401

399402
return self
400403

0 commit comments

Comments
 (0)