Skip to content

Commit e1038e6

Browse files
committed
add driver property for Database
1 parent d170d70 commit e1038e6

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

simple_query_builder/database.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,21 @@ def __call__(cls, *args, **kwargs):
1717

1818

1919
class DataBase(metaclass=MetaSingleton):
20-
db_name = "db.db"
20+
driver = "sqlite"
21+
db_name = ":memory:"
2122
conn = None
2223
cursor = None
2324

24-
def connect(self, db_name=""):
25-
if db_name != "":
2625
def connect(self, db_name: str = "", uri: bool = False):
2726
if db_name:
2827
self.db_name = db_name
2928

3029
if self.conn is None:
31-
self.conn = sqlite3.connect(self.db_name, uri=uri)
32-
self.cursor = self.conn.cursor()
30+
if self.driver == "sqlite":
31+
self.conn = sqlite3.connect(self.db_name, uri=uri)
32+
self.cursor = self.conn.cursor()
33+
else:
34+
print("Wrong DB driver. At present time it's supported 'sqlite' only")
3335

3436
return self.conn
3537

simple_query_builder/querybuilder.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ def column(self, column: Union[str, int] = 0):
212212
self.set_error(f"Incorrect type of column in {inspect.stack()[0][3]} method. Result dict is {self._result_dict}")
213213
return self
214214

215-
self.query("", (), self._FETCH_COLUMN, column)
215+
self.query(fetch=self._FETCH_COLUMN, column=column)
216216
return self._result
217217

218218
def pluck(self, key: Union[str, int] = 0, column: Union[str, int] = 1):
@@ -245,7 +245,7 @@ def get_last(self):
245245
return self._result[-1]
246246

247247
def exists(self) -> bool:
248-
result = self.one()
248+
self.one()
249249
return self._count > 0
250250

251251
def _prepare_aliases(self, items: Union[str, list, dict], as_list: bool = False) -> Union[str, list]:
@@ -688,6 +688,7 @@ def __str__(self):
688688
return self.get_sql(False)
689689

690690
def create_view(self, view_name: str, add_exists: bool = True):
691+
# this method will be moved to another class
691692
if not view_name:
692693
self.set_error(f"Empty view_name in {inspect.stack()[0][3]} method")
693694
return self
@@ -703,6 +704,7 @@ def create_view(self, view_name: str, add_exists: bool = True):
703704
return self
704705

705706
def drop_view(self, view_name: str, add_exists: bool = True):
707+
# this method will be moved to another class
706708
if not view_name:
707709
self.set_error(f"Empty view_name in {inspect.stack()[0][3]} method")
708710
return self

0 commit comments

Comments
 (0)