Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render Tag #471

Closed
YuiYukihira opened this issue Jun 15, 2022 · 3 comments · Fixed by #506
Closed

Render Tag #471

YuiYukihira opened this issue Jun 15, 2022 · 3 comments · Fixed by #506

Comments

@YuiYukihira
Copy link
Contributor

Hi, sorry if this is a misunderstanding on my part.

But looking online, the "include" tag is deprecated and the render tag should be used instead.

I was wondering what the status of this is and if there is any intention to add the new tag? Thanks
@epage
Copy link
Member

epage commented Jun 15, 2022

Yes, we need to resolve #419 and close the gap on that. Unfortunately, a lot of my attention is elsewhere atm so I'm not getting to spend as much time on liquid as I would like

@YuiYukihira
Copy link
Contributor Author

Thanks for confirming this for me. Would you be willing to accept a PR for the render tag if I were to make one?

@epage
Copy link
Member

epage commented Jun 20, 2022

Most definitely!

@YuiYukihira YuiYukihira mentioned this issue Jun 22, 2022
Closed
epage pushed a commit to epage/liquid-rust that referenced this issue Jun 9, 2023
@YuiYukihira @epage
feat: Add render tag
980cd00 
The main functionality missing is `as <name>` should be optional,
defaulting to the partial's file name.

For background, see
- https://shopify.dev/docs/api/liquid/tags/render
- https://github.com/Shopify/liquid/blob/master/lib/liquid/tags/render.rb
- https://github.com/Shopify/liquid/blob/master/test/integration/tags/render_tag_test.rb

Fixes cobalt-org#471
@epage epage mentioned this issue Jun 9, 2023
Merged
epage pushed a commit to epage/liquid-rust that referenced this issue Jun 9, 2023
@YuiYukihira @epage
feat: Add render tag
c248b49 
The main functionality missing is `as <name>` should be optional,
defaulting to the partial's file name.

For background, see
- https://shopify.dev/docs/api/liquid/tags/render
- https://github.com/Shopify/liquid/blob/master/lib/liquid/tags/render.rb
- https://github.com/Shopify/liquid/blob/master/test/integration/tags/render_tag_test.rb

Fixes cobalt-org#471
@epage epage closed this as completed in #506 Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add render tag epage/liquid-rust
2 participants
@epage @YuiYukihira