feat(lib): Add render tag #472

YuiYukihira · 2022-06-22T23:17:06Z

Hey, here's my PR for #471.

See the description including

the selected template cannot access any variables from the parent scope
- I've created a new OpaqueStackFrame struct, I needed a way to make sure that only the variables passed into the render tag could be accessed from inside it.
the selected template's variables do not leak into the parent scope
variables can be passed to the template with either key: value syntax or with with <var> [as <var>]
rendered content can be looped over with for <value> [as <var>] and the template has access to forloop
- I moved the ForloopObject and Range structs into a parent module, this is because I wanted to use them for the for variant of the render tag.

crates/lib/src/stdlib/tags/render_tag.rs

crates/core/src/runtime/stack.rs

crates/lib/src/stdlib/blocks/for_block.rs

epage · 2022-06-23T03:21:56Z

crates/lib/src/stdlib/tags/render_tag.rs

+    }
+
+    fn description(&self) -> &str {
+        ""


Mind putting one in?

epage

I'm sorry for the long delay; somehow I lost track of this.

epage · 2023-01-09T16:50:19Z

crates/lib/src/stdlib/tags/render_tag.rs

+                        // given that we're at the end of the loop body
+                        // already, dealing with a `continue` signal is just
+                        // clearing the interrupt and carrying on as normal. A
+                        // `break` requires some special handling, though.
+                        let current_interrupt =
+                            scope.registers().get_mut::<InterruptRegister>().reset();
+                        if let Some(Interrupt::Break) = current_interrupt {
+                            break;


Do we need any tests for this?

This section is pretty much an exact copy from here, in this project. I can't see any specific tests for it there.

crates/lib/src/stdlib/tags/render_tag.rs

YuiYukihira · 2023-05-03T00:40:43Z

No worries, I completely forgot about this too.

epage · 2023-06-09T18:01:01Z

... no idea why my push closed this but it won't let me re-open. I'll create a new PR

epage · 2023-06-09T18:02:41Z

This is now superseded by #506

Felt bad at how slow I've been at getting back to you so I went ahead and wrapped this up

Noticed that , variables can be used with with and for, so I adjusted that
Ported the ruby tests so we know what works and what doesn't.
- The main thing we don't yet support is as being optional. It should take the file name of the partial to serve as the variable name

epage · 2023-06-09T18:11:05Z

v0.26.4 is now out with render tag support