testing: fix some cops

Author: tylerjl

.rubocop.yml

@@ -16,6 +16,9 @@ Metrics/LineLength:
 Metrics/MethodLength:
   Enabled: false
 
+Metrics/ParameterLists:
+  Enabled: false
+
 Style/AndOr:
   Enabled: false
 

lib/puppet/provider/elastic_rest.rb

@@ -26,7 +26,6 @@ def metadata
   #
   # @return Net::HTTPResponse
   # rubocop:disable Metrics/CyclomaticComplexity
-  # rubocop:disable Metrics/ParameterLists
   # rubocop:disable Metrics/PerceivedComplexity
   def self.rest(http, \
                 req, \
@@ -61,7 +60,6 @@ def self.rest(http, \
     end
   end
   # rubocop:enable Metrics/CyclomaticComplexity
-  # rubocop:enable Metrics/ParameterLists
   # rubocop:enable Metrics/PerceivedComplexity
 
   # Helper to format a remote URL request for Elasticsearch which takes into
@@ -86,7 +84,6 @@ def self.format_uri(resource_path, property_flush = {})
   # @return Array
   #   an array of Hashes representing the found API objects, whether they be
   #   templates, pipelines, et cetera.
-  # rubocop:disable Metrics/ParameterLists
   def self.api_objects(protocol = 'http', \
                        validate_tls = true, \
                        host = 'localhost', \
@@ -116,7 +113,6 @@ def self.api_objects(protocol = 'http', \
 
     results
   end
-  # rubocop:enable Metrics/ParameterLists
 
   # Process the JSON response body
   def self.process_body(body)

spec/helpers/acceptance/tests/datadir_shared_examples.rb

@@ -35,7 +35,7 @@
           json = JSON.parse(response.body)['nodes'].values.first
           expect(
             json['settings']['path']['data']
-          ).to (datapaths.one? and v[:elasticsearch_major_version] <= 2) ? eq(datapaths.first) : contain_exactly(*datapaths)
+          ).to((datapaths.one? and v[:elasticsearch_major_version] <= 2) ? eq(datapaths.first) : contain_exactly(*datapaths))
         end
       end
     end