Merge pull request voxpupuli#715 from tylerjl/yml-unquoted-numerics

Enforce proper numeric datatypes in config hash

Author: tylerjl

CHANGELOG.md

@@ -14,6 +14,7 @@
 
 #### Changes
 * The `api_ca_file` and `api_ca_path` parameters have been added to support custom CA bundles for API access.
+* Numerics in elasticsearch.yml will always be properly unquoted.
 
 #### Testing changes
 

spec/templates/001_elasticsearch.yml.erb_spec.rb

@@ -74,4 +74,16 @@ def unindent
       }.config))
   end
 
+  it 'should not quote numeric values' do
+    harness.set(
+      '@data', {
+        'some.setting' => '10'
+      }
+    )
+
+    expect( YAML.load(harness.run) ).to eq( YAML.load(%q{
+      some.setting: 10
+    }.config))
+  end
+
 end

templates/etc/elasticsearch/elasticsearch.yml.erb

@@ -1,14 +1,19 @@
 ### MANAGED BY PUPPET ###
 <%-
   $LOAD_PATH.unshift(File.join(File.dirname(__FILE__),"..","..","..","lib"))
+  require 'puppet_x/elastic/deep_to_i'
   require 'puppet_x/elastic/hash'
 
   @yml_string = ''
 
   if [email protected]?
 
     # Sort Hash and transform it into yaml
-    @yml_string += @data.extend(Puppet_X::Elastic::SortedHash).to_yaml
+    @yml_string += Puppet_X::Elastic::deep_to_i(
+      @data
+    ).extend(
+      Puppet_X::Elastic::SortedHash
+    ).to_yaml
 
     # Puppet < 4 uses ZAML, which has some deviations from Puppet 4 YAML
     # implementation