Skip to content

Commit 6fdf21b

Browse files
jellymartinpitt
authored andcommitted
css: move CSS declarations above nested rules
The new SASS version warns that decelerations should appear above nested rules. This change should not have any visual impact. > ▲ [WARNING] Sass's behavior for declarations that appear after nested rules will be changing to match the behavior specified by CSS in an upcoming version. To keep the existing behavior, move the declaration above the nested rule. To opt into the new behavior, wrap the declaration in `& {}`.
1 parent 84c27d8 commit 6fdf21b

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

src/components/storagePools/storagePoolList.scss

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,10 @@
11
#storage-pools-listing {
2+
// Approximate size of text
3+
// (overflows work, but will knock out alignment)
4+
--progress-text: 8rem;
5+
--progress-bar-min: 2rem;
6+
--progress-bar-max: 12vw;
7+
28
.pf-v5-c-table tbody > tr > * {
39
// These tables are 1 row tall; progress bar does odd stuff for alignment;
410
// vertical alignment makes text line up
@@ -10,12 +16,6 @@
1016
margin-block-start: 0;
1117
}
1218

13-
// Approximate size of text
14-
// (overflows work, but will knock out alignment)
15-
--progress-text: 8rem;
16-
--progress-bar-min: 2rem;
17-
--progress-bar-max: 12vw;
18-
1919
td[data-label="Size"] {
2020
> .pf-v5-c-progress {
2121
// Fix progress bar size

src/components/vm/vmReplaceSpiceDialog.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
.spice-replace-dialog-panel {
2+
// separate it a bit from the text above
3+
margin-block-start: var(--pf-v5-global--spacer--md);
4+
25
// drop excessive inside spacing
36
.pf-v5-c-panel__main-body {
47
padding-block-start: 0;
58
padding-block-end: 0;
69
padding-inline-start: 0;
710
padding-inline-end: 0;
811
}
9-
10-
// but separate it a bit from the text above
11-
margin-block-start: var(--pf-v5-global--spacer--md);
1212
}
1313

1414
.spice-replace-dialog-popover-list {

0 commit comments

Comments
 (0)