Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disks should not become shared without explicit user consent #2011

Open
shodanshok opened this issue Jan 31, 2025 · 0 comments
Open

Disks should not become shared without explicit user consent #2011

shodanshok opened this issue Jan 31, 2025 · 0 comments

Comments

@shodanshok
Copy link

Currently, when an user add an already-in-use RAW volume to another virtual machine, the disk is attached as a "shared writable" volume and, at the same time, such a change is scheduled for the first virtual machine also. Sharing a disk in this manner poses a significant risks as, when the two virtual machines start, they will both try to open the underlying volume and corruption will quickly happen. The only warning the user see is a yellow/orange triangle and a (small) orange statement that the disk will become shared.

Changing a disk from "writeble" to "shared writable" should be done only after explicit user consent and never be easy to accidentally trigger. virt-manager does exactly that: it asks the user if the disk should really be added to another virtual machine and, after that, does not automatically marks the disk as shared. So user not only needs to confirm the add operation, but it has to enable the "shareable" flag on both machines before allowing them to start.

Please do the same for cockpit-machines. As a side note, the add disk via "custom path" form does not automatically change the "shareable" flag, so removing this behavior from the "use existing" disk form is going to present a more consistent (and much safer) behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant