FIXUP: Make test parallel friendly

This doesn't fully work: Actually running tests in parallel causes
podman hiccups:
```
Error: reading CIDFile: open /tmp/tmplgrkkdaq/cidfile: no such file or directory
RuntimeError: Failed to create container
```

Author: martinpitt

test/conftest.py

@@ -20,6 +20,7 @@ def pytest_exception_interact(node, call, report):
         else:
             print('\n\n---------- cockpit-tasks log ------------')
             sys.stdout.flush()
-            subprocess.run(['podman', 'exec', '-i', 'cockpituous-tasks', 'cat', '/tmp/cockpit-tasks.log'])
+            subprocess.run(['podman', 'exec', '-i', f'cockpituous-tasks-{os.getpid()}',
+                            'cat', '/tmp/cockpit-tasks.log'])
             print('-----------------------------------------')
             sys.stdout.flush()

test/test_deployment.py

@@ -17,6 +17,10 @@
 from pytest_container.pod import Pod, PodData, PodLauncher
 from testinfra.host import Host
 
+# we want to have useful pod/container names for interactive debugging and log dumping, but still allow parallel tests
+# (with e.g. xdist) so disambiguate them with the pid
+TEST_INSTANCE = str(os.getpid())
+
 TASKS_IMAGE = os.environ.get('TASKS_IMAGE', 'ghcr.io/cockpit-project/tasks:latest')
 ROOT_DIR = Path(__file__).parent.parent
 COMMON_LAUNCH_ARGS = ['--stop-timeout=0', '--security-opt=label=disable']
@@ -113,7 +117,7 @@ def pod(config: Config, pytestconfig) -> PodData:
     # RabbitMQ
     containers.append(Container(
         url='docker.io/rabbitmq',
-        extra_launch_args=[*COMMON_LAUNCH_ARGS, '--name', 'cockpituous-rabbitmq'],
+        extra_launch_args=[*COMMON_LAUNCH_ARGS, '--name', f'cockpituous-rabbitmq-{TEST_INSTANCE}'],
         volume_mounts=[
             BindMount('/etc/rabbitmq', host_path=config.rabbitmq, flags=[VolumeFlag.READ_ONLY]),
             BindMount('/run/secrets/webhook', host_path=config.webhook, flags=[VolumeFlag.READ_ONLY]),
@@ -123,7 +127,7 @@ def pod(config: Config, pytestconfig) -> PodData:
     # minio S3 store
     containers.append(Container(
         url='quay.io/minio/minio',
-        extra_launch_args=[*COMMON_LAUNCH_ARGS, '--name', 'cockpituous-s3'],
+        extra_launch_args=[*COMMON_LAUNCH_ARGS, '--name', f'cockpituous-s3-{TEST_INSTANCE}'],
         # that's what we want, but not in latest release yet: https://github.com/dcermak/pytest_container/issues/182
         # extra_entrypoint_args=['server', '/data', '--console-address', ':9001'],
         entry_point=EntrypointSelection.BASH,
@@ -143,7 +147,7 @@ def pod(config: Config, pytestconfig) -> PodData:
     containers.append(Container(
         url='quay.io/minio/mc',
         custom_entry_point='/bin/sh',
-        extra_launch_args=[*COMMON_LAUNCH_ARGS, '--name', 'cockpituous-mc'],
+        extra_launch_args=[*COMMON_LAUNCH_ARGS, '--name', f'cockpituous-mc-{TEST_INSTANCE}'],
         volume_mounts=[
             BindMount('/etc/pki/ca-trust/source/anchors/ca.pem', host_path=config.secrets / 'ca.pem',
                       flags=[VolumeFlag.READ_ONLY]),
@@ -153,7 +157,7 @@ def pod(config: Config, pytestconfig) -> PodData:
     # tasks
     containers.append(Container(
         url=TASKS_IMAGE,
-        extra_launch_args=[*COMMON_LAUNCH_ARGS, '--name', 'cockpituous-tasks'],
+        extra_launch_args=[*COMMON_LAUNCH_ARGS, '--name', f'cockpituous-tasks-{TEST_INSTANCE}'],
         volume_mounts=[
             BindMount('/run/secrets/webhook', host_path=config.webhook, flags=[VolumeFlag.READ_ONLY]),
             BindMount('/run/secrets/tasks', host_path=config.tasks, flags=[VolumeFlag.READ_ONLY]),
@@ -186,7 +190,7 @@ def pod(config: Config, pytestconfig) -> PodData:
     if have_webhook_container:
         containers.append(Container(
             url=TASKS_IMAGE,
-            extra_launch_args=[*COMMON_LAUNCH_ARGS, '--name', 'cockpituous-webhook'],
+            extra_launch_args=[*COMMON_LAUNCH_ARGS, '--name', f'cockpituous-webhook-{TEST_INSTANCE}'],
             # that's what we want, but https://github.com/dcermak/pytest_container/issues/182
             # extra_entrypoint_args=['webhook'],
             volume_mounts=[
@@ -203,8 +207,9 @@ def pod(config: Config, pytestconfig) -> PodData:
         containers=containers,
         forwarded_ports=[
             # BUG: host_port= would be nice to make S3 log URLs work; but it has no effect:
-            # https://github.com/dcermak/pytest_container/issues/190
-            PortForwarding(container_port=9000, host_port=9000),  # S3
+            # https://github.com/dcermak/pytest_container/issues/190; but also, we want to keep the test
+            # parallel-friendly
+            PortForwarding(container_port=9000),  # S3
             PortForwarding(container_port=9001),  # minio console
         ]
     )
@@ -215,7 +220,8 @@ def pod(config: Config, pytestconfig) -> PodData:
         for c in containers:
             c._is_local = True
 
-    with PodLauncher(pod_cockpituous, rootdir=pytestconfig.rootpath, pod_name='cockpituous') as launcher:
+    with PodLauncher(pod_cockpituous, rootdir=pytestconfig.rootpath,
+                     pod_name=f'cockpituous-{TEST_INSTANCE}') as launcher:
         launcher.launch_pod()
 
         # run minio in lieu of extra_entrypoint_args